From owner-freebsd-current@FreeBSD.ORG Tue Apr 6 11:25:46 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 84F3816A4CE for ; Tue, 6 Apr 2004 11:25:46 -0700 (PDT) Received: from hak.cnd.mcgill.ca (hak.cnd.mcgill.ca [132.216.11.133]) by mx1.FreeBSD.org (Postfix) with ESMTP id D86B643D55 for ; Tue, 6 Apr 2004 11:25:45 -0700 (PDT) (envelope-from mat@hak.cnd.mcgill.ca) Received: from hak.cnd.mcgill.ca (localhost [127.0.0.1]) by hak.cnd.mcgill.ca (8.12.9/8.12.8) with ESMTP id i36IQOK0081339; Tue, 6 Apr 2004 14:26:24 -0400 (EDT) (envelope-from mat@hak.cnd.mcgill.ca) Received: (from mat@localhost) by hak.cnd.mcgill.ca (8.12.9/8.12.8/Submit) id i36IQO0s081338; Tue, 6 Apr 2004 14:26:24 -0400 (EDT) Date: Tue, 6 Apr 2004 14:26:24 -0400 From: Mathew Kanner To: Doug White Message-ID: <20040406182624.GA79561@cnd.mcgill.ca> References: <20040406103912.R89264@carver.gumbysoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040406103912.R89264@carver.gumbysoft.com> User-Agent: Mutt/1.4.1i Organization: I speak for myself, operating in Montreal, CANADA X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.62 X-Spam-Checker-Version: SpamAssassin 2.62 (2004-01-11) on hak.cnd.mcgill.ca cc: freebsd-current@freebsd.org cc: Mathew Kanner Subject: Re: dev/sound/pcm/sound.h shadows INTR_MPSAFE declaration X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2004 18:25:46 -0000 On Apr 06, Doug White wrote: > On Tue, 6 Apr 2004, Yuriy Tsibizov wrote: > > > > > Today I've noticied that my driver is marked as Giant-locked: > > > > > > Is it actually MPSAFE? If so, feel free to mark it as such, > > > although pcm > > > isn't fully locked yet, so we take no responsibility for any damage > > > caused :) > > > > Some sound drivers in -CURRENT allocate interrupts with INTR_MPSAFE. > > The problem is that after including dev/sound/pcm/sound.h INTR_MPSAFE no longer equals to 512, but it is set to 0. And if sound driver interrupt was allocated as INTR_TYPE_AV|INTR_MPSAFE it will be marked only as INTR_TYPE_TTY. > > Ever think that might be intentional? :) I'd poke -multimedia to get the > sound driver folks, though. Hello All, I've noticed the same things. I think I tried once to allow for it to MPSAFE (when I was mucking around with the emu10k1 driver). I think if you poke further, the sound drivers aren't always locked properly and hence not MPSAFE. I won't have time to dig into this until friday. --Mat -- It's impossible to awaken a man who is pretending to be asleep. - Navajo saying