From owner-svn-src-all@freebsd.org Tue Jun 30 03:16:26 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E20199076D for ; Tue, 30 Jun 2015 03:16:26 +0000 (UTC) (envelope-from jmmv@meroh.net) Received: from mail-qk0-f182.google.com (mail-qk0-f182.google.com [209.85.220.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2FEC62904 for ; Tue, 30 Jun 2015 03:16:25 +0000 (UTC) (envelope-from jmmv@meroh.net) Received: by qkbp125 with SMTP id p125so104564987qkb.2 for ; Mon, 29 Jun 2015 20:16:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=v3ZntdUndV1mpos31whYE0yGa2mQDKW/qggDMZO5MAc=; b=eN35fqjebMxz/R1WAoD1eVUHswz9jfY+ao07qfT3QCfITqMQQJxzGPZQEgJ+ddbRlK aDbaF66JauD8mnuw7twz700EsFRj4u7Ud/gl3usNM1qGUif5z4Gpj4ehmp8IHnxwUy93 7tYXjVRaQh4SYi5/5sIJ7NDBm7DBWVLqYZ/qC6hIQauyFyZ5idhcCdm72fJ0xy3bKwBo qdJXiQi72AYR5iei0/fPS6+qIN9JJS9Y3J/gOCtdpVHLwTAaTcbQZLYeKgrJ5fRTku2K L2LFerhNL+f4FSyXY2r9iwpt3TDuidz7W1fF/uk5JTIhK5YozH/A6W8vK89uylNzfTXG oNsw== X-Gm-Message-State: ALoCoQneMCnunjSgw8e7r9Hc85GuRa9/W84uZcX04EIAv/Obu8b7o6oXzArxgYC0SzNNAZjLqSzo X-Received: by 10.55.18.14 with SMTP id c14mr38521683qkh.51.1435634178898; Mon, 29 Jun 2015 20:16:18 -0700 (PDT) Received: from lime.meroh.net (cpe-24-90-142-167.nyc.res.rr.com. [24.90.142.167]) by mx.google.com with ESMTPSA id c88sm12542153qge.26.2015.06.29.20.16.17 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Jun 2015 20:16:18 -0700 (PDT) Sender: Julio Merino Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: Re: svn commit: r284912 - head/usr.bin/units From: Julio Merino In-Reply-To: Date: Mon, 29 Jun 2015 23:16:16 -0400 Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <6A6AEA93-6E0B-4CB2-93B0-059235190A4C@FreeBSD.org> References: <201506281643.t5SGh7D9009454@svn.freebsd.org> To: Garrett Cooper X-Mailer: Apple Mail (2.2098) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jun 2015 03:16:26 -0000 > On Jun 28, 2015, at 15:05 , Garrett Cooper = wrote: >=20 >=20 >> On Jun 28, 2015, at 09:43, Julio Merino wrote: >>=20 >> Author: jmmv >> Date: Sun Jun 28 16:43:07 2015 >> New Revision: 284912 >> URL: https://svnweb.freebsd.org/changeset/base/284912 >>=20 >> Log: >> Only initialize libedit when necessary >>=20 >> The code path to support units conversions from the command line >> need not initialize neither libedit nor the history. Therefore, only = do >> that when in interactive mode. >>=20 >> This hides the issue reported in PR bin/201167 whereby running = commands >> of the form 'echo "$(units ft in)"' would corrupt the terminal. The = real >> issue causing the corruption most likely still remains somewhere. >>=20 >> PR: bin/201167 >> Differential Revision: D2935 >> Reviewed by: eadler >=20 > Jenkins has been so messed up recently with timeouts and the like that = it's hard to tell where things went south.. >=20 > Can you please add your TERM and locale variables to the PR? I suspect = that it might be a related issue.. Details added, but I don=E2=80=99t think they make a difference. Could = reproduce the above under multiple combinations.=