From owner-cvs-all@FreeBSD.ORG Sun Apr 17 07:08:58 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7D19D16A4CE; Sun, 17 Apr 2005 07:08:58 +0000 (GMT) Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1471F43D41; Sun, 17 Apr 2005 07:08:58 +0000 (GMT) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (localhost [127.0.0.1]) by VARK.MIT.EDU (8.13.3/8.13.1) with ESMTP id j3H78sQ3036314; Sun, 17 Apr 2005 03:08:54 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.MIT.EDU (8.13.3/8.13.1/Submit) id j3H78sP7036313; Sun, 17 Apr 2005 03:08:54 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Date: Sun, 17 Apr 2005 03:08:54 -0400 From: David Schultz To: Jeff Roberson Message-ID: <20050417070854.GA36122@VARK.MIT.EDU> Mail-Followup-To: Jeff Roberson , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200504162347.j3GNlJUA010418@repoman.freebsd.org> <20050417013241.O67458@mail.chesapeake.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050417013241.O67458@mail.chesapeake.net> cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/fs/msdosfs msdosfs_lookup.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Apr 2005 07:08:58 -0000 On Sun, Apr 17, 2005, Jeff Roberson wrote: > On Sat, 16 Apr 2005, David Schultz wrote: > > > das 2005-04-16 23:47:19 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/fs/msdosfs msdosfs_lookup.c > > Log: > > Disable negative name caching for msdosfs to work around a bug. > > Since the name cache is case-sensitive and msdosfs isn't, > > creating a file 'foo' won't invalidate a negative entry for 'FOO'. > > There are similar problems related to 8.3 filenames. > > > > A better solution is to override VOP_LOOKUP with a method that > > canonicalizes the name, then calls vfs_cache_lookup(). Unfortunately, > > it's not quite that simple because vfs_cache_lookup() will call > > msdosfs_lookup() on a cache miss, and msdosfs_lookup() needs a way to > > get at the original component name. > > Use cache_lookup() directly rather than vfs_cache_lookup. It won't try to > call VOP_CACHEDLOOKUP. Yeah thanks, I remembered that after this commit---see the sketch of a complete solution in my email to Mike.