From owner-freebsd-current Wed Sep 29 11:49: 6 1999 Delivered-To: freebsd-current@freebsd.org Received: from wall.polstra.com (rtrwan160.accessone.com [206.213.115.74]) by hub.freebsd.org (Postfix) with ESMTP id 7A313150D0 for ; Wed, 29 Sep 1999 11:48:50 -0700 (PDT) (envelope-from jdp@polstra.com) Received: from vashon.polstra.com (vashon.polstra.com [206.213.73.13]) by wall.polstra.com (8.9.3/8.9.3) with ESMTP id LAA17063; Wed, 29 Sep 1999 11:48:50 -0700 (PDT) (envelope-from jdp@polstra.com) From: John Polstra Received: (from jdp@localhost) by vashon.polstra.com (8.9.3/8.9.1) id LAA22988; Wed, 29 Sep 1999 11:48:48 -0700 (PDT) (envelope-from jdp@polstra.com) Date: Wed, 29 Sep 1999 11:48:48 -0700 (PDT) Message-Id: <199909291848.LAA22988@vashon.polstra.com> To: marcel@scc.nl Subject: Re: HEADS UP: sigset_t changes committed In-Reply-To: <37F23064.98EEBC67@scc.nl> References: <37F23064.98EEBC67@scc.nl> Organization: Polstra & Co., Seattle, WA Cc: current@freebsd.org Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Following up on my previous mail regarding the panic on the Alpha, I've been looking at the diff for the code in question, in "src/sys/nfs/nfs_socket.c": @@ -1501,14 +1502,16 @@ struct nfsreq *rep; register struct proc *p; { + sigset_t tmpset; + tmpset = p->p_siglist; + SIGSETNAND(tmpset, p->p_sigmask); + SIGSETNAND(tmpset, p->p_sigignore); if (rep && (rep->r_flags & R_SOFTTERM)) return (EINTR); if (!(nmp->nm_flag & NFSMNT_INT)) return (0); - if (p && p->p_siglist && - (((p->p_siglist & ~p->p_sigmask) & ~p->p_sigignore) & - NFSINT_SIGMASK)) + if (p && SIGNOTEMPTY(p->p_siglist) && NFSINT_SIGMASK(tmpset)) return (EINTR); return (0); } It looks like the old code was prepared for "p" to be NULL, but the new code assumes it is non-NULL. GDB is _still_ looking for the bottom of the stack. If it ever finds it, I'll send that part of the backtrace. :-) John -- John Polstra jdp@polstra.com John D. Polstra & Co., Inc. Seattle, Washington USA "No matter how cynical I get, I just can't keep up." -- Nora Ephron To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message