From owner-freebsd-audit Fri May 31 9:57:59 2002 Delivered-To: freebsd-audit@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 61B8937B405 for ; Fri, 31 May 2002 09:57:48 -0700 (PDT) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 2033B5307; Fri, 31 May 2002 18:57:47 +0200 (CEST) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Bruce Evans Cc: Dima Dorfman , Subject: Re: %j for printf(9) References: <20020531205803.L32389-100000@gamplex.bde.org> From: Dag-Erling Smorgrav Date: 31 May 2002 18:57:46 +0200 In-Reply-To: <20020531205803.L32389-100000@gamplex.bde.org> Message-ID: Lines: 24 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Bruce Evans writes: > I don't remember all the context for this. Is everything restructured so > that all the va_arg()'s for fetching integers are in the above patch? Yes. > If so, consider the following further restructurings: > > - merge fetch_nosign with nosign (rename it to something like > handle_unsigned) and use it handle all the unsigned cases that are now > handled by fetch_number. > - rename fetch_number to handle_signed and use it for only the signed cases > (%d and %+z). These two would actually increase code duplication. > - don't bother explicitly casting to uintmax_t for the signed cases. In > -current, these casts are used for %+z but not for %d. OK. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message