From owner-freebsd-current@FreeBSD.ORG Fri Jan 30 23:46:16 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 426F3AF3 for ; Fri, 30 Jan 2015 23:46:16 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1A2DB9E8 for ; Fri, 30 Jan 2015 23:46:16 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net [173.54.116.245]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id F1E81B915; Fri, 30 Jan 2015 18:46:12 -0500 (EST) From: John Baldwin To: Elizabeth Myers Subject: Re: Questions on adding backlight support for the i915 driver Date: Fri, 30 Jan 2015 18:45:56 -0500 Message-ID: <3595567.zVLW9tlg0N@ralph.baldwin.cx> User-Agent: KMail/4.14.2 (FreeBSD/10.1-STABLE; KDE/4.14.2; amd64; ; ) In-Reply-To: <54CC0999.90500@interlinked.me> References: <54C883E7.4000300@interlinked.me> <54CBA0A4.30708@FreeBSD.org> <54CC0999.90500@interlinked.me> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 30 Jan 2015 18:46:13 -0500 (EST) Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jan 2015 23:46:16 -0000 On Friday, January 30, 2015 04:45:45 PM Elizabeth Myers wrote: > On 01/30/15 09:17, John Baldwin wrote: > > Humm. If the code is going to live in the drm driver, then I would > > start with hanging a sysctl off of the drm device itself. (Each new-bus > > device_t has a sysctl ctx you can get to hang new nodes off of the > > device's node.) > > I'm wondering if that's the correct place for it to live. So far it's > the only real place it *can* live that makes logical sense imho, unless > anyone has better ideas. > > This is awesome. As for upower, it should probably be patched to know > about other types of brightness sysctls if/when this is implemented. For now I think hanging it off of the device_t is fine. It can be moved later if there is an urgent need. However, I suspect that tools like upower will need updating regardless of where it ends up living. -- John Baldwin