From owner-svn-src-head@freebsd.org Tue Jan 9 17:48:32 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09101E66726 for ; Tue, 9 Jan 2018 17:48:32 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BFA6E63F97 for ; Tue, 9 Jan 2018 17:48:31 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x231.google.com with SMTP id b77so9393098itd.0 for ; Tue, 09 Jan 2018 09:48:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=uA8gvuG8XsN5vBKk5CKpE9fdUEEYCKwKpQRxIkuKqNg=; b=URxWOIHKeQ5cYWtDoG0N8yPNsLXNwSbeiCT7K31Zy21izxo6MwrZpAav2I0I6BLT5o OJZXqxyOU4IVcQ+XO0IIqYNoxR/kMzWvrHgG/q2YF1miKhYh4M/SoIabj8DKw6zQZGag AMkZA8pAGL3Zt4Xmu4BNZ512LTUMPnsNRATSPSHJmcAxI3N2zA8s7cHmx+iQTGFTOhiB hXXJ0o/RXFjFu5A00z7RQ8k0d+XQDoAc6JXXgquxgH3+GNKh96WD7AAFA9m5GDkM1imj HYanU8869uIXH4VFs8qJiX7Wn45R+IQeoVT+cMrjdUha9kot33CVMCOrdT+C7JkgQrSA Pp/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=uA8gvuG8XsN5vBKk5CKpE9fdUEEYCKwKpQRxIkuKqNg=; b=Si4eK9yxABv6tDpQtQWw0XB4zlO+wWPeM0khmxBwyT9gvou/esOAtixFU4uhYNXhpc MjhM1c/fxi1C9INcTe660EYxk3ANES5owT+GZzA5ZtVOX7H5alLztLYaxFv/NUl4tqLN zIXJv7t6gX7PrNtAXl1klGTcwkImFcnJXoOa7KyMNJug+e5g/Qj+OANBlY7hKYuUL1wi FMhelTcZJpa6GHv+sK8ecIG9y1nK6lY2bWeXR5OvB7kvRTiJWxhdtHERbSdPZP1Ila0O f0RqQEJKz7PKJa+LiFMSDKW0qDsUtqwoxsKdBzPPqzjxszR+rDHySe/6+958Nol9Jgwu O20A== X-Gm-Message-State: AKGB3mIUvT+AaZQGX3Li2M0KMti0u+GmD2vNz07dcZO/5d3cKWRd9aqd 5Lqxurk9FtwES7tBnEjbocRnYpcve8ZOcnNdMP36vQ== X-Google-Smtp-Source: ACJfBouWn8LLRwpGP7K7bW/Cx37XEXo211orzaCH2Xp92uHYSGH2jLDGcAECHZpR41Cwl1y+BmFCmhD/rdmh0O5CZ5s= X-Received: by 10.36.74.200 with SMTP id k191mr17037618itb.69.1515520110840; Tue, 09 Jan 2018 09:48:30 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.160.217 with HTTP; Tue, 9 Jan 2018 09:48:30 -0800 (PST) X-Originating-IP: [50.253.109.65] In-Reply-To: <1620808.I0a57TDRna@ralph.baldwin.cx> References: <201801081847.w08IlZ7F033684@repo.freebsd.org> <1620808.I0a57TDRna@ralph.baldwin.cx> From: Warner Losh Date: Tue, 9 Jan 2018 10:48:30 -0700 X-Google-Sender-Auth: _7LeqX-G8ElTKISAwH5jLcrZtRU Message-ID: Subject: Re: svn commit: r327705 - head/stand/mips/beri/common To: John Baldwin Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 17:48:32 -0000 On Tue, Jan 9, 2018 at 10:05 AM, John Baldwin wrote: > On Monday, January 08, 2018 12:02:09 PM Warner Losh wrote: > > This should have been a nop... libsa specifically creates 'safe' headers > > for all the standard ones. > > > > Ah, libsa creates a perfectly fine stdint.h, but not a inttypes.h... > > Would you prefer it to use stdint.h and stdio.h rather than stand.h? No. stand.h is fine. I just wondered why you hit issues at all with stdio.h. inttypes.h isn't supported because we don't implement the extra functions defined there over stdint.h, so it should have given an error when included. I'm just surprised I didn't catch it in my universe.sh script that I use to build all loaders though... Warner > > Warner > > > > On Mon, Jan 8, 2018 at 11:47 AM, John Baldwin wrote: > > > > > Author: jhb > > > Date: Mon Jan 8 18:47:35 2018 > > > New Revision: 327705 > > > URL: https://svnweb.freebsd.org/changeset/base/327705 > > > > > > Log: > > > Use instead of and in boot code. > > > > > > In the freestanding boot compile environment, standard headers are > not > > > available. Curiously, only building with clang exposed this as > compiles > > > with external GCC still succeeded. > > > > > > Sponsored by: DARPA / AFRL > > > > > > Modified: > > > head/stand/mips/beri/common/sdcard.c > > > > > > Modified: head/stand/mips/beri/common/sdcard.c > > > ============================================================ > > > ================== > > > --- head/stand/mips/beri/common/sdcard.c Mon Jan 8 18:46:10 > 2018 > > > (r327704) > > > +++ head/stand/mips/beri/common/sdcard.c Mon Jan 8 18:47:35 > 2018 > > > (r327705) > > > @@ -33,8 +33,7 @@ > > > #include > > > #include > > > > > > -#include > > > -#include > > > +#include > > > > > > > > > /* > > > > > > > > > -- > John Baldwin >