From owner-svn-src-all@FreeBSD.ORG Mon Jan 4 19:53:17 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 791EB1065695; Mon, 4 Jan 2010 19:53:17 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 4835D8FC13; Mon, 4 Jan 2010 19:53:17 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id EB68046B7F; Mon, 4 Jan 2010 14:53:16 -0500 (EST) Received: from jhbbsd.localnet (unknown [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 50CDB8A026; Mon, 4 Jan 2010 14:53:16 -0500 (EST) From: John Baldwin To: Max Laier Date: Mon, 4 Jan 2010 11:01:18 -0500 User-Agent: KMail/1.12.1 (FreeBSD/7.2-CBSD-20091103; KDE/4.3.1; amd64; ; ) References: <200912312044.nBVKicMb003815@svn.freebsd.org> <200912311547.54045.jhb@freebsd.org> <201001010635.33081.max@love2party.net> In-Reply-To: <201001010635.33081.max@love2party.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201001041101.18288.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 04 Jan 2010 14:53:16 -0500 (EST) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00, DATE_IN_PAST_03_06,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r201351 - head/sys/net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2010 19:53:17 -0000 On Friday 01 January 2010 12:35:33 am Max Laier wrote: > On Thursday 31 December 2009 21:47:54 John Baldwin wrote: > > On Thursday 31 December 2009 3:44:38 pm John Baldwin wrote: > > > Author: jhb > > > Date: Thu Dec 31 20:44:38 2009 > > > New Revision: 201351 > > > URL: http://svn.freebsd.org/changeset/base/201351 > > > > > > Log: > > > Use stricter checking to match possible vlan clones by not allowing > > > extra garbage characters around or within the tag. > > > > Previously some odd clone requests such as 'em0.102a', 'em0.10a3bc', and > > 'em0.foo.104' would have succeeded creating interfaces equivalent to > > em0.102, em0.103, and em0.104. > > The em0.foo.104 case seems quite useful, though. Maybe we can keep that > /feature/? Err, I would only find it useful for adding a '104' vlan to a 'em0.foo' interface. Otherwise it is ambiguous. Suppose you have an em0 and an em0.foo interface already, then what should em0.foo.104 do in that case? I think the only way that this auto-cloning makes sense if it is an exact match of . as it is documented to be. -- John Baldwin