From owner-cvs-all@FreeBSD.ORG Sat Jul 9 03:37:31 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1191916A41C; Sat, 9 Jul 2005 03:37:31 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A49143D46; Sat, 9 Jul 2005 03:37:30 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.3/8.13.3) with ESMTP id j693hZjn041318; Fri, 8 Jul 2005 21:43:35 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <42CF4672.2090204@samsco.org> Date: Fri, 08 Jul 2005 21:37:22 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050615 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Maxim Sobolev References: <200507081837.j68Ib0IM082223@repoman.freebsd.org> <42CECCD8.5070201@portaone.com> <42CEEF12.4070904@samsco.org> <20050709033317.GA64401@www.portaone.com> In-Reply-To: <20050709033317.GA64401@www.portaone.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org Cc: Roman Kurakin , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/ndis subr_ntoskrnl.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jul 2005 03:37:31 -0000 Maxim Sobolev wrote: > On Fri, Jul 08, 2005 at 03:24:34PM -0600, Scott Long wrote: > >>>I think the better fix is to change type of k_lock member from void* to >>>the struct mtx*, I've already commited such change to the RELENG_5 few >>>days ago. >>> >>>-Maxim >> >>It's a void* for portability with other OS's. This work has already >>been ported >>to Solaris, and maybe even other OS's by now. Reducing the portability is a >>bad idea, and will likely get you smacked around by Bill when he >>notices. I'd >>highly recommend not doing this again in the future. > > > Even if so, rik's version is no better since it adds explicit cast > (two of them in fact) to struct mtx*. Either way it will break > portability with other OSes. Therefore, they are on par, but my > solution is more clear wrt FreeBSD. > > -Maxim subr_ntoskrnl.c explicitely uses the FreeBSD mtx API, so adding FreeBSD casts is fine. Polluting the common headers, as you did, is not the same thing. Scott