From owner-svn-src-all@freebsd.org Mon Jan 22 13:39:05 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C2FDDEC1722; Mon, 22 Jan 2018 13:39:05 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 876FF7C1E3; Mon, 22 Jan 2018 13:39:05 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.55.3]) by phk.freebsd.dk (Postfix) with ESMTP id 6DEBE27376; Mon, 22 Jan 2018 13:39:03 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.15.2/8.15.2) with ESMTPS id w0MDclsI088072 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 22 Jan 2018 13:38:47 GMT (envelope-from phk@critter.freebsd.dk) Received: (from phk@localhost) by critter.freebsd.dk (8.15.2/8.15.2/Submit) id w0MDclF9088071; Mon, 22 Jan 2018 13:38:47 GMT (envelope-from phk) To: Emmanuel Vadot cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules In-reply-to: <20180122135905.203e19ce94510854777dff63@bidouilliste.com> From: "Poul-Henning Kamp" References: <201801220710.w0M7AUm9091853@repo.freebsd.org> <20180122135905.203e19ce94510854777dff63@bidouilliste.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <88069.1516628327.1@critter.freebsd.dk> Content-Transfer-Encoding: quoted-printable Date: Mon, 22 Jan 2018 13:38:47 +0000 Message-ID: <88070.1516628327@critter.freebsd.dk> X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 13:39:05 -0000 -------- In message <20180122135905.203e19ce94510854777dff63@bidouilliste.com>, Emm= anuel Vadot writes: >> +#if 0 >> + // XXX: default state is disabled in RPI3 DTB, assume for now >> + // XXX: that people want the PWM to work if the KLD this module. >> if (!ofw_bus_status_okay(dev)) >> return (ENXIO); >> +#endif > > This is really bad, one need to use overlay to enable the node. > Leaving this I will predict that in the near futur you will have >someone complaining that he set to load the module at boot, unplug is >pwm testing gear and plug another type of HAT and that it makes funny >thing. As long as you don't set any of dev.pwm.0.* sysctls, the bcm283x_pwm driver doesn't do anything, so that situation is harmless. > Can you please revert this part ? Once I find out how to get similar behaviour, ie: kldload without having to reboot to load a DT-overlay. My preference would be that DT-overlays could be compiled into kmods, but I'm fine with any reasonable commahd that can load an overlay without a reboot. Or alternatively, a command which will change the "status=3Ddisable" to "status=3Dokay" in the already loaded DT ? -- = Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe = Never attribute to malice what can adequately be explained by incompetence= .