From owner-svn-src-all@FreeBSD.ORG Tue May 28 20:04:58 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id DE7DEC26 for ; Tue, 28 May 2013 20:04:57 +0000 (UTC) (envelope-from peter@wemm.org) Received: from mail-vb0-x233.google.com (mail-vb0-x233.google.com [IPv6:2607:f8b0:400c:c02::233]) by mx1.freebsd.org (Postfix) with ESMTP id 9E449299 for ; Tue, 28 May 2013 20:04:57 +0000 (UTC) Received: by mail-vb0-f51.google.com with SMTP id x16so5612999vbf.38 for ; Tue, 28 May 2013 13:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wemm.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=gQtM8Dmeht3Bx6dij3qwGBX605ZeJ6vSbxHVAiRWjZw=; b=OPYM8kRPmaMLjJyL731OnWAVbH9q+jBmTAGaFM5W5GwiAjFNl9aPk1Um5tYOnN4v4h naibxAx8JlmfPqF1EkLqFs7Bgo7Yqlk4xI0un9iJc7lgS6MsvleQVmat1vI9SYJgDmNB qxttcLXUL2C4AzcMNdwfVu1KpH/j09BoS9cVA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-gm-message-state; bh=gQtM8Dmeht3Bx6dij3qwGBX605ZeJ6vSbxHVAiRWjZw=; b=ejdiiygdHKala1Qzoh01GGyUbPTPqfns8ERjdylninr0ObV2id26sKxbO7mLeQZPVh 7lypf6aYVnEbqEZIuloJS04Pbk4/qFTX8f5hHPNpN02nPsUTENqgTmGSCBeJ3Se+NXR8 EBuJr1yJC+3Kmi0HZFWDigxuzmVeN7n6yBEhRrDpQMTE3IWZqBlk3cnkTfaJ/F3kmxpg agxpG0/WADoj/YLaCsm52ahWTWROJ6ljcMWG2MVGDGc5PTZVKG5LNUdhSv9mcPueRO1E 2eIqi5G7w5wVCRlPMbU8sdr8jdiXs37UA9ZeWw3ly1Ton82yabc4R0wmP/KqkLe5Y2PI wfag== MIME-Version: 1.0 X-Received: by 10.220.76.137 with SMTP id c9mr3069827vck.48.1369771497172; Tue, 28 May 2013 13:04:57 -0700 (PDT) Received: by 10.220.119.2 with HTTP; Tue, 28 May 2013 13:04:56 -0700 (PDT) In-Reply-To: <201305280952.r4S9qShX012991@svn.freebsd.org> References: <201305280952.r4S9qShX012991@svn.freebsd.org> Date: Tue, 28 May 2013 13:04:56 -0700 Message-ID: Subject: Re: svn commit: r251058 - head From: Peter Wemm To: =?ISO-8859-1?Q?Dag=2DErling_Sm=F8rgrav?= Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQllobYsVh3mE84/KqpKJpBydo7acQ+UQgrLCW57+oBHwIlCcAXYKjbtmCj3AUxJhnL8sbtL Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 May 2013 20:04:58 -0000 On Tue, May 28, 2013 at 2:52 AM, Dag-Erling Sm=F8rgrav wr= ote: > Author: des > Date: Tue May 28 09:52:28 2013 > New Revision: 251058 > URL: http://svnweb.freebsd.org/changeset/base/251058 > > Log: > During buildkernel, print a banner before building modules. > > Modified: > head/Makefile.inc1 > > Modified: head/Makefile.inc1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/Makefile.inc1 Tue May 28 09:51:27 2013 (r251057) > +++ head/Makefile.inc1 Tue May 28 09:52:28 2013 (r251058) > @@ -983,9 +983,16 @@ buildkernel: > .endif > @echo > @echo "----------------------------------------------------------= ----" > - @echo ">>> stage 3.2: building everything" > + @echo ">>> stage 3.2: building the kernel" > @echo "----------------------------------------------------------= ----" > - cd ${KRNLOBJDIR}/${_kernel}; ${KMAKE} all -DNO_MODULES_OBJ > + cd ${KRNLOBJDIR}/${_kernel}; ${KMAKE} kernel-all -DNO_MODULES_OBJ > + @echo > +.if !defined(MODULES_WITH_WORLD) && !defined(NO_MODULES) && exists(${KER= NSRCDIR}/modules) > + @echo "----------------------------------------------------------= ----" > + @echo ">>> stage 3.3: building the modules" > + @echo "----------------------------------------------------------= ----" > + cd ${KRNLOBJDIR}/${_kernel}; ${KMAKE} modules-all -DNO_MODULES_OB= J > +.endif > @echo "----------------------------------------------------------= ----" > @echo ">>> Kernel build for ${_kernel} completed on `LC_ALL=3DC d= ate`" > @echo "----------------------------------------------------------= ----" Please back this out or fix it ASAP. You broke every single machine in the freebsd.org cluster. make: don't know how to make modules-all. Stop *** [buildkernel] Error code 2 You are causing it to stop respecting makeoptions in the kernel config files. eg: eg: makeoptions NO_MODULES=3Dno or makeoptions MODULES_OVERRIDE=3D"zfs opensolaris" If you really want this echo here then you're going to need to reach down into the internals and make 'modules-all' work even when NO_MODULES is set. --=20 Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV