From nobody Mon Mar 28 23:40:55 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1E8121A4699A; Mon, 28 Mar 2022 23:40:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KS8Mr0NZDz4h7v; Mon, 28 Mar 2022 23:40:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648510856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IHK1bAFM1m6tPh5nBC+5/+MA/c2NRjaQstJJ7Ef+b0w=; b=DwkwIdS8dTzTiDvHMpUWl7ne9WBG8nsqNS1OxTYe2AYSOZj/w0iHKBFBbUXutWrazDx3ZQ BGc5j5RlD4vAZ+L0wpCxyXLyZ9WwCxScRt6NUgRESKBZ4BtT9fUAyXikyRiCox5U6sb3fk N8+0Osv8JvRilWpemPw3zQCe9enVIHpMxnkHIJt9ThIRO98zcKk918/W/j5aNpAdx4M9hp mK/ixMFED4ReFmhnnbMN4GY39dTXt/GKON/XOYpdbf8dX0x2f5flHEeMNRb/E7CPCYgRV5 Qi4EzwbjDOZmJp6idFrbChiPjX0NxGdgP0GfBJDCANoSfmPsF4r1nPyjvgePHg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D696613CFE; Mon, 28 Mar 2022 23:40:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 22SNetOt059534; Mon, 28 Mar 2022 23:40:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 22SNetT1059533; Mon, 28 Mar 2022 23:40:55 GMT (envelope-from git) Date: Mon, 28 Mar 2022 23:40:55 GMT Message-Id: <202203282340.22SNetT1059533@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Jamie Gritton Subject: git: c1576434e9cf - stable/13 - mfc jail: handle jailsys parameters in modification permission test List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jamie X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: c1576434e9cf9c48b4d3975717c9f6cc6427cfd9 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648510856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IHK1bAFM1m6tPh5nBC+5/+MA/c2NRjaQstJJ7Ef+b0w=; b=PsdQwiBu8wLX6nun1DE0irg+XOFFRXS4Lch4o6D0Acxn/FLprkzcvNtgmwk7U3GyGjRJrp TX66y9gagNXvrKSTNFLwtIady+cGu0oHndCU0Zi0BGWnxxJhfX1vUSOAm9PnRf/CPanA/B unBHJsv7cStY16nBSZM3LZIMPy+QwJlxsFC21T0f29YCY48qTJhJIfkrfT452i7UqSYhhA WEeES7RXunZtnU0bgNYdE+otg8RVnDX8fJlyKq9kIa1NTopic9IRo/zi8N6nsOu/fSqfqv nCjLfSqcLhINMJr7/C9hyNFSA0nKypsy3WAu+I6GHDElpQ2XrYB6i79d33OvQw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1648510856; a=rsa-sha256; cv=none; b=nvx/qpb1hXMR1nZ77usnK95iIl8L8ulu7YK4NRVMK7Lyy4lzW2fkXxsGRFEEIBAMknJrhA DQrAd/nh0JhtyFsiRyAZ2bRidhfmH2mNZb8IoBzN9zOhPAc8xVFJ8NgQQ6ah/DznJX5iEc IN0QQMJPTVTQkgyaXDzeHJ3/FiIsli4dC7+jkhQaD3VncWrNJcRWFEcwdlQKyjGTBPDMnP xLPLe2XcoIgsoLVf3exM6ndbne/bAyj+EZrT4GWF9l3RBAi3Xfm/d7iSGjeXvsQOLUzdYS IePax8+ogpIhx5llnRIl3tQJhmesdfGT6YaOAbqQLN4lAmGKowD2KXxFuIpuZg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by jamie: URL: https://cgit.FreeBSD.org/src/commit/?id=c1576434e9cf9c48b4d3975717c9f6cc6427cfd9 commit c1576434e9cf9c48b4d3975717c9f6cc6427cfd9 Author: Jamie Gritton AuthorDate: 2022-03-26 02:16:51 +0000 Commit: Jamie Gritton CommitDate: 2022-03-28 23:39:54 +0000 mfc jail: handle jailsys parameters in modification permission test Avoid a null dereference when a value-less jailsys parameter is passed to "jail -m". There was already code to handle boolean parameters, but in reality any parameter could be passed without a value. PR: 262471 Reported by: jcaplan at blackberry.com (cherry picked from commit 8f1543785f77086494c73310ba8f5d09b61ff7eb) --- usr.sbin/jail/jail.c | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/usr.sbin/jail/jail.c b/usr.sbin/jail/jail.c index eb3b19f2cb82..63096146f176 100644 --- a/usr.sbin/jail/jail.c +++ b/usr.sbin/jail/jail.c @@ -790,7 +790,9 @@ static int rdtun_params(struct cfjail *j, int dofail) { struct jailparam *jp, *rtparams, *rtjp; - int nrt, rval; + const void *jp_value; + size_t jp_valuelen; + int nrt, rval, bool_true; if (j->flags & JF_RDTUN) return 0; @@ -818,15 +820,25 @@ rdtun_params(struct cfjail *j, int dofail) rtjp = rtparams + 1; for (jp = j->jp; rtjp < rtparams + nrt; jp++) { if (JP_RDTUN(jp) && strcmp(jp->jp_name, "jid")) { - if (!((jp->jp_flags & (JP_BOOL | JP_NOBOOL)) && - jp->jp_valuelen == 0 && - *(int *)jp->jp_value) && - !(rtjp->jp_valuelen == jp->jp_valuelen && - !((jp->jp_ctltype & CTLTYPE) == - CTLTYPE_STRING ? strncmp(rtjp->jp_value, - jp->jp_value, jp->jp_valuelen) : - memcmp(rtjp->jp_value, jp->jp_value, - jp->jp_valuelen)))) { + jp_value = jp->jp_value; + jp_valuelen = jp->jp_valuelen; + if (jp_value == NULL && jp_valuelen > 0) { + if (jp->jp_flags & (JP_BOOL | + JP_NOBOOL | JP_JAILSYS)) { + bool_true = 1; + jp_value = &bool_true; + jp_valuelen = sizeof(bool_true); + } else if ((jp->jp_ctltype & CTLTYPE) == + CTLTYPE_STRING) + jp_value = ""; + else + jp_valuelen = 0; + } + if (rtjp->jp_valuelen != jp_valuelen || + (CTLTYPE_STRING ? strncmp(rtjp->jp_value, + jp_value, jp_valuelen) + : memcmp(rtjp->jp_value, jp_value, + jp_valuelen))) { if (dofail) { jail_warnx(j, "%s cannot be " "changed after creation",