From owner-cvs-src@FreeBSD.ORG Tue Oct 16 17:10:09 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5196B16A41B for ; Tue, 16 Oct 2007 17:10:09 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from spacemail2-out.mgmt.space.net (spacemail2-out.mgmt.Space.Net [194.97.149.148]) by mx1.freebsd.org (Postfix) with ESMTP id D385C13C45A for ; Tue, 16 Oct 2007 17:10:08 +0000 (UTC) (envelope-from se@FreeBSD.org) X-SpaceNet-SBRS: None X-IronPort-AV: E=Sophos;i="4.21,284,1188770400"; d="scan'208";a="69714765" Received: from mail.atsec.com ([195.30.252.105]) by spacemail2-out.mgmt.space.net with ESMTP; 16 Oct 2007 19:10:06 +0200 Received: from [10.2.2.88] (frueh.atsec.com [217.110.13.170]) (Authenticated sender: se@atsec.com) by mail.atsec.com (Postfix) with ESMTP id DC58F91C544; Tue, 16 Oct 2007 19:10:05 +0200 (CEST) Message-ID: <4714F06B.7070702@FreeBSD.org> Date: Tue, 16 Oct 2007 19:10:03 +0200 From: Stefan Esser User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Ceri Davies References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016102013.GE23043@submonkey.net> In-Reply-To: <20071016102013.GE23043@submonkey.net> X-Enigmail-Version: 0.95.3 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 17:10:09 -0000 Ceri Davies schrieb: > On Mon, Oct 15, 2007 at 10:09:19PM +0000, Stefan Esser wrote: >> se 2007-10-15 22:09:19 UTC >> >> FreeBSD src repository >> >> Modified files: >> usr.bin/locate/locate updatedb.sh >> Log: >> Make the updatedb script installed as /usr/libexec/locate.updatedb >> inspect all local file systems, not only ufs and ext2fs. A number >> of local file systems has been added over time, and at least zfs >> has the potential to become a popular choice. Without this change >> a ZFS root file system causes the script to ignore all file-systems >> and leads to an empty locate db. (An alternative is to add all the >> relevant file systems individually, which means that at least zfs, >> xfs, ntfs, ntfs-3g, msdosfs should be added, probably more). > > This now includes /dev, /dev/fd, /proc, /compat/linux/proc, CD-ROMs and DVDs > as well as duplicating everything in nullfs mounts, all of which are probably > undesirable -- well, they are undesirable to me; whether they are to > others is the question ;-). Ok, thank you for the information. I did not notice this in my tests. I'm not sure what the "local" pseudo fs-type is meant to be used for. Currently it appears to be identical to "not-remote" (which is what the locate db update tries to avoid, due to high network load and scan time). I plan to fix this within the next 24 hours (if anybody thinks it needs to be backed-out immediately, I'm willing to do this, but I'd rather put in the correct fix instead. Two possibilities: We could have another pseudo fs-type in find, which selects "real" file systems (and skips devfs, procfs, fdescfs, nullfs and probably more). Scanning of removable devices is dubious, too, independently of their file system. By selecting "local" and "disk based" file systems (which would omit not only the pseudo file-systems and nullfs, but also cd9660 and udf), no specific file systems needed to be put into the script (and find would have the knowledge). The second possibility is to extend the list in the update script. It needs to contain at least: ufs ext2fs zfs and probably also: xfs msdosfs ntfs ntfs-3g (?) Did I forget any? In fact, I'd rather enter "ufs ext2fs zfs xfs msdosfs ntfs" right now, instead of relying on the pseudo-fs definition in find, now that I think about it. Any opinions or comments? > Also, the example in /etc/locate.rc should be updated to avoid > misleading users into thinking that ufs is the only filesystem searched > (granted, this was wrong before). I'll fix this at the same time, but want to wait a few hours for some feedback. Regards, STefan