From owner-cvs-src@FreeBSD.ORG  Mon Feb 14 16:25:38 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6295C16A4D5; Mon, 14 Feb 2005 16:25:38 +0000 (GMT)
Received: from ylpvm01.prodigy.net (ylpvm01-ext.prodigy.net [207.115.57.32])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C5A9543D45; Mon, 14 Feb 2005 16:25:37 +0000 (GMT)
	(envelope-from nate@root.org)
Received: from [10.0.5.51] (adsl-64-171-186-189.dsl.snfc21.pacbell.net
	[64.171.186.189])j1EGPZvE019531;	Mon, 14 Feb 2005 11:25:36 -0500
Message-ID: <4210D0FF.6000904@root.org>
Date: Mon, 14 Feb 2005 08:25:35 -0800
From: Nate Lawson <nate@root.org>
User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041205)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Scott Long <scottl@FreeBSD.org>
References: <20050214112155.C531A16A514@hub.freebsd.org>
In-Reply-To: <20050214112155.C531A16A514@hub.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/acpi/acpidump acpi.c acpidump.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Feb 2005 16:25:38 -0000

Scott Long wrote:
> scottl      2005-02-14 11:21:48 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     usr.sbin/acpi/acpidump acpi.c acpidump.h 
>   Log:
>   Add support for parsing MCFG tables.
>   
>   Revision  Changes    Path
>   1.31      +24 -0     src/usr.sbin/acpi/acpidump/acpi.c
>   1.20      +12 -0     src/usr.sbin/acpi/acpidump/acpidump.h

Great.

> --- src/usr.sbin/acpi/acpidump/acpidump.h:1.19	Tue Oct  5 20:45:05 2004
> +++ src/usr.sbin/acpi/acpidump/acpidump.h	Mon Feb 14 11:21:48 2005
> @@ -293,6 +293,18 @@
>  	u_char		ec_id[1];	/* Variable length name string */
>  } __packed;
>  
> +/* Memory Mapped PCI config space base allocation structure */
> +struct MCFGbody {
> +	uint8_t		rsvd[8];
> +	struct {
> +		uint64_t	baseaddr;	/* Base Address */
> +		uint16_t	seg_grp;	/* Segment group number */
> +		uint8_t		start;		/* Starting bus number */
> +		uint8_t		end;		/* Ending bus number */
> +		uint8_t		rsvd[4];	/* Reserved */
> +	} s[];
> +} __packed;
> +

Don't we usually use s[1] for variable-length arrays?  Is there 
versioning on this table for acpi 2/3 when they might expand it?

-- 
Nate