From owner-svn-src-all@FreeBSD.ORG Mon May 21 18:28:24 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC6D21065676; Mon, 21 May 2012 18:28:24 +0000 (UTC) (envelope-from gad@FreeBSD.org) Received: from smtp5.server.rpi.edu (smtp5.server.rpi.edu [128.113.2.225]) by mx1.freebsd.org (Postfix) with ESMTP id 30D668FC0A; Mon, 21 May 2012 18:28:23 +0000 (UTC) Received: from gilead.netel.rpi.edu (gilead.netel.rpi.edu [128.113.124.121]) by smtp5.server.rpi.edu (8.13.1/8.13.1) with ESMTP id q4LHK6rE007508; Mon, 21 May 2012 13:20:06 -0400 Message-ID: <4FBA7946.7040702@FreeBSD.org> Date: Mon, 21 May 2012 13:20:06 -0400 From: Garance A Drosehn User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.9) Gecko/20100722 Eudora/3.0.4 MIME-Version: 1.0 To: John Baldwin References: <201205181001.q4IA1VED044374@svn.freebsd.org> <201205180941.48076.jhb@freebsd.org> <20120518152436.GA9116@reks> <201205211127.34052.jhb@freebsd.org> In-Reply-To: <201205211127.34052.jhb@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Bayes-Prob: 0.0001 (Score 0) X-RPI-SA-Score: 2.30 (**) [Hold at 8.00] COMBINED_FROM, INFO_TLD, RATWARE_GECKO_BUILD X-CanItPRO-Stream: outgoing X-Canit-Stats-ID: 49638602 - cb1303eee5ea X-Scanned-By: CanIt (www . roaringpenguin . com) on 128.113.2.225 Cc: svn-src-head@FreeBSD.org, Gleb Kurtsou , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r235601 - head/include/protocols X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2012 18:28:24 -0000 On 5/21/12 11:27 AM, John Baldwin wrote: > On Friday, May 18, 2012 11:24:36 am Gleb Kurtsou wrote: > >> On (18/05/2012 09:41), John Baldwin wrote: >> >>> A question about your stat changes: did you expand dev_t to 32 bits >>> for the AFS folks, or did you leave it as 16 bits? >> dev_t is already 32-bit. Changing it to 64-bit was discussed at some >> point and from what I recall no decision was made: >> >> http://marc.info/?t=129119478700005&r=1&w=2 >> >> I'm going to commit preparatory changes only for now. Then publish >> diff for testing. We can still change dev_t to 64-bit if needed. >> Although I didn't work on it. >> > Ah, it was 64-bit they asked for. If it is easy to do so, I'd favor > changing it since you've already done all the hard work of rolling a > new stat structure. I'd rather err on wasting 32-bits for dev_t than > having to do all this over again. > I would also like to see dev_t changed to 64-bits as part of these 'stat' changes, if that won't cause too much work. It should be less work to do it as part of these changes than to do it later! If changing dev_t to 64-bits turns out to be too much work right now, then maybe we could at least reserve a 64-bit space and have the current dev_t be the low-order 32-bits of that space. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu