Date: Fri, 16 Mar 2012 16:56:21 -0500 From: Jeremy Messenger <mezz.freebsd@gmail.com> To: bf1783@gmail.com Cc: freebsd-ports@freebsd.org Subject: Re: lang/lua: It does need gmake. Message-ID: <CADLFttfUMNCPXGOKNfttfsWfahN2yzme42rrKOTDQFK6YMoVqw@mail.gmail.com> In-Reply-To: <CAGFTUwOs2ayVp3CbUt-oj0J0UWxZ-RisV6idQufwWEmxFCicQQ@mail.gmail.com> References: <CAGFTUwOs2ayVp3CbUt-oj0J0UWxZ-RisV6idQufwWEmxFCicQQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 16, 2012 at 5:49 AM, b. f. <bf1783@googlemail.com> wrote: > Jeremy Messenger wrote: >> On Thu, Mar 15, 2012 at 6:23 PM, Chuck Swiger <cswiger at mac.com> wrote= : >> > On Mar 15, 2012, at 4:18 PM, Jeremy Messenger wrote: >> >> Figured out. Add custom CFLAGS in the make.conf and you will get a >> >> build failure with make but not gmake. Here's what I have in my >> >> make.conf: >> >> >> >> CFLAGS=3D -O2 -fno-strict-aliasing -pipe -g >> >> STRIP=3D >> > >> > Does it work properly if you use "CFLAGS+=3D" instead? >> >> It will, but you do not need to put '+' in make.conf. I have same >> CFLAGS for years and years, btw. > > If you have been making these assignments unconditionally, then for > years and years you have been in danger of breaking or damaging the > builds for many ports that explicitly invoke make(1) more than once > (and thus read make.conf more than once), by clobbering prior changes > to CFLAGS or STRIP that are made in port makefiles. =A0Despite the > misleading examples in the base-system example make.conf, this kind of > customization is not supported for Ports, and not encouraged. =A0You > should take steps to ensure that your custom values are set only once, > before any top-level port Makefile is parsed. =A0You can define them > conditionally, or move them to another makefile that is included only > once, or disable multiple inclusions of make.conf for Ports by using > something like "__MAKE_CONF=3D/dev/null" in the right place. Any ports have to respect the CFLAGS, see the porter handbook. If it fails to do then it needs to be fixed. Add '+' in the make.conf is not right way to do it as it's merely add in exists CFLAGS. mandree, thanks for took care of it! Cheers, Mezz > b. --=20 mezz.freebsd@gmail.com - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLFttfUMNCPXGOKNfttfsWfahN2yzme42rrKOTDQFK6YMoVqw>