From owner-freebsd-ports@FreeBSD.ORG Fri Mar 16 21:56:22 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AE5251065675 for ; Fri, 16 Mar 2012 21:56:22 +0000 (UTC) (envelope-from mezz.freebsd@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 740488FC15 for ; Fri, 16 Mar 2012 21:56:22 +0000 (UTC) Received: by iahk25 with SMTP id k25so8088359iah.13 for ; Fri, 16 Mar 2012 14:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=wdnfrayIdKs1oPF+RFNe+muVWWxIQHK8T/g+dEBqv7k=; b=vX6ogEgUJUlew85cSj+NqJWe8qqUXQpnjjujSukLLxlSfIOv9KmHcOIbRMqy0EueXR t0rLkL0Bi9/T7GXPZCCeigKd4tgy4CXcNFRMcI6pEI+Mktnod7Ate1ToZSluz6Pppnei De9KKP1clfLNWVrkH1cRzO8u9E3LqT92XHTKCvRL1pRC49FO7NthbfMyfeQ2iU0TyfyV +2K0KnJuh90ko4Tn6u7kDauUH5VodnAb0C9TegJvq8ikTOa/3ITPALED7JS9t3b4JK1b wbvjtJ0ydwVYxpbRtvpMBj99Jc4q7KLDjoxoYLvbUvC/De7VTIPDmAvF6UG41/0dMCqH Llbw== MIME-Version: 1.0 Received: by 10.50.42.134 with SMTP id o6mr529363igl.72.1331934982023; Fri, 16 Mar 2012 14:56:22 -0700 (PDT) Received: by 10.42.217.202 with HTTP; Fri, 16 Mar 2012 14:56:21 -0700 (PDT) In-Reply-To: References: Date: Fri, 16 Mar 2012 16:56:21 -0500 Message-ID: From: Jeremy Messenger To: bf1783@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-ports@freebsd.org Subject: Re: lang/lua: It does need gmake. X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2012 21:56:22 -0000 On Fri, Mar 16, 2012 at 5:49 AM, b. f. wrote: > Jeremy Messenger wrote: >> On Thu, Mar 15, 2012 at 6:23 PM, Chuck Swiger wrote= : >> > On Mar 15, 2012, at 4:18 PM, Jeremy Messenger wrote: >> >> Figured out. Add custom CFLAGS in the make.conf and you will get a >> >> build failure with make but not gmake. Here's what I have in my >> >> make.conf: >> >> >> >> CFLAGS=3D -O2 -fno-strict-aliasing -pipe -g >> >> STRIP=3D >> > >> > Does it work properly if you use "CFLAGS+=3D" instead? >> >> It will, but you do not need to put '+' in make.conf. I have same >> CFLAGS for years and years, btw. > > If you have been making these assignments unconditionally, then for > years and years you have been in danger of breaking or damaging the > builds for many ports that explicitly invoke make(1) more than once > (and thus read make.conf more than once), by clobbering prior changes > to CFLAGS or STRIP that are made in port makefiles. =A0Despite the > misleading examples in the base-system example make.conf, this kind of > customization is not supported for Ports, and not encouraged. =A0You > should take steps to ensure that your custom values are set only once, > before any top-level port Makefile is parsed. =A0You can define them > conditionally, or move them to another makefile that is included only > once, or disable multiple inclusions of make.conf for Ports by using > something like "__MAKE_CONF=3D/dev/null" in the right place. Any ports have to respect the CFLAGS, see the porter handbook. If it fails to do then it needs to be fixed. Add '+' in the make.conf is not right way to do it as it's merely add in exists CFLAGS. mandree, thanks for took care of it! Cheers, Mezz > b. --=20 mezz.freebsd@gmail.com - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org