Date: Thu, 6 Jan 2011 14:22:59 +1100 From: Peter Jeremy <peterjeremy@acm.org> To: gahr@FreeBSD.org Cc: Stanislav Sedov <stas@FreeBSD.org>, cvs-ports@FreeBSD.org, Alexey Dokuchaev <danfe@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/graphics/freeimage Makefile distinfo pkg-descr ports/graphics/freeimage/files patch-Source-LibOpenJPEG_opj_malloc.h Message-ID: <20110106032259.GB62507@server.vk2pj.dyndns.org> In-Reply-To: <20110104092747.GJ72669@gahrfit.gahr.ch> References: <201012200900.oBK90cfc062324@repoman.freebsd.org> <20101220103733.GA6738@FreeBSD.org> <20101220110727.GT7557@gahrfit.gahr.ch> <20101230161846.16ad0b3c.stas@FreeBSD.org> <20110104092747.GJ72669@gahrfit.gahr.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
--pWyiEgJYm5f9v55/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2011-Jan-04 10:27:47 +0100, Pietro Cerutti <gahr@gahr.ch> wrote: >Well I tend to disagree here. I see a commit message as a way to convey >important notes about a commit. And I see a commit message as explaining _why_ the change was made. >I would like to avoid to have to write a line like this > >- add a patch file to fix an include line that used the deprecated > header alloc.h instead of stdlib.h > >for a patch file like this > >- #include <alloc.h> >+ #include <stdlib.h> OTOH, I would like to see such a patch file documented along the lines of: - Patch to replace deprecated alloc.h with stdlib.h (But I wouldn't make fuss if it was skipped). --=20 Peter Jeremy --pWyiEgJYm5f9v55/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (FreeBSD) iEYEARECAAYFAk0lNZMACgkQ/opHv/APuIcfKACdFK4vE90RbzuMtkBmXI8kP1N4 HzAAnRRmwZmXXS55PRJTeApIj08FkgDC =DJNK -----END PGP SIGNATURE----- --pWyiEgJYm5f9v55/--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110106032259.GB62507>