Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 11 Jul 2017 10:02:36 -0700 (PDT)
From:      "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
To:        Edward Tomasz Napierala <trasz@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r320892 - head/etc/defaults
Message-ID:  <201707111702.v6BH2aFe080928@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <201707111232.v6BCWeXu073060@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ]
> Author: trasz
> Date: Tue Jul 11 12:32:40 2017
> New Revision: 320892
> URL: https://svnweb.freebsd.org/changeset/base/320892
> 
> Log:
>   Make fsck_y_enable default to passing pass -R to fsck_ffs(8) in addition
>   to -y.  To me, fsck_y_enable means "try as hard as possible", and without
>   -R, it... well, doesn't.

To you perhaps, but it has long been and is well known that fsck -y is
just that, fsck -y, not something more.  If you want it to be more
your already given a tunable.

I now have to "detune" all installed systems using fsck_y_enable if
I do not want them to do this.

>   
>   Reviewed by:	mckusick
>   Obtained from:	CheriBSD
>   MFC after:	2 weeks
>   Sponsored by:	DARPA, AFRL
>   Differential Revision:	https://reviews.freebsd.org/D11490
> 
> Modified:
>   head/etc/defaults/rc.conf
> 
> Modified: head/etc/defaults/rc.conf
> ==============================================================================
> --- head/etc/defaults/rc.conf	Tue Jul 11 06:39:12 2017	(r320891)
> +++ head/etc/defaults/rc.conf	Tue Jul 11 12:32:40 2017	(r320892)
> @@ -92,7 +92,7 @@ geli_autodetach="YES"	# Automatically detach on last c
>  root_rw_mount="YES"	# Set to NO to inhibit remounting root read-write.
>  root_hold_delay="30"	# Time to wait for root mount hold release.
>  fsck_y_enable="NO"	# Set to YES to do fsck -y if the initial preen fails.
      ^^^ this variable and this           ^^^^^^ this comment are now wrong

Would probably be better to introduce a new varaible for this.

> -fsck_y_flags=""		# Additional flags for fsck -y
> +fsck_y_flags="-T ffs:-R -T ufs:-R"	# Additional flags for fsck -y
>  background_fsck="YES"	# Attempt to run fsck in the background where possible.
>  background_fsck_delay="60" # Time to wait (seconds) before starting the fsck.
>  netfs_types="nfs:NFS smbfs:SMB" # Net filesystems.
> 
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201707111702.v6BH2aFe080928>