From owner-svn-src-head@FreeBSD.ORG  Fri Dec 17 02:43:20 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 58833106564A;
	Fri, 17 Dec 2010 02:43:20 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 34EE08FC14;
	Fri, 17 Dec 2010 02:43:18 +0000 (UTC)
Received: from [127.0.0.1] (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id oBH2e2eC099339;
	Thu, 16 Dec 2010 19:40:03 -0700 (MST) (envelope-from imp@bsdimp.com)
Message-ID: <4D0ACD82.3030303@bsdimp.com>
Date: Thu, 16 Dec 2010 19:40:02 -0700
From: Warner Losh <imp@bsdimp.com>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.12) Gecko/20101029 Thunderbird/3.1.6
MIME-Version: 1.0
To: Garrett Cooper <gcooper@FreeBSD.org>
References: <201012161754.oBGHsu5d071652@svn.freebsd.org>
	<AANLkTinpdt8UqKd1Ot2SU5bGfe1jULorrG_sC=vBwUCa@mail.gmail.com>
In-Reply-To: <AANLkTinpdt8UqKd1Ot2SU5bGfe1jULorrG_sC=vBwUCa@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, "David E. O'Brien" <obrien@FreeBSD.org>
Subject: Re: svn commit: r216493 - head/sbin/geom/class/eli
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Dec 2010 02:43:20 -0000

On 12/16/2010 11:54, Garrett Cooper wrote:
> On Thu, Dec 16, 2010 at 9:54 AM, David E. O'Brien<obrien@freebsd.org>  wrote:
>> Author: obrien
>> Date: Thu Dec 16 17:54:56 2010
>> New Revision: 216493
>> URL: http://svn.freebsd.org/changeset/base/216493
>>
>> Log:
>>   Revert r216473.
>>   WARNS=6 causes "warning: cast increases required alignment of target type"
>>   on arm, ia64, mips, and sparc64.
>>
>> Modified:
>>   head/sbin/geom/class/eli/Makefile
>>
>> Modified: head/sbin/geom/class/eli/Makefile
>> ==============================================================================
>> --- head/sbin/geom/class/eli/Makefile   Thu Dec 16 17:14:37 2010        (r216492)
>> +++ head/sbin/geom/class/eli/Makefile   Thu Dec 16 17:54:56 2010        (r216493)
>> @@ -11,7 +11,7 @@ SRCS+=        sha2.c
>>   DPADD= ${LIBMD} ${LIBCRYPTO}
>>   LDADD= -lmd -lcrypto
>>
>> -WARNS?=        6
>> +WARNS?=        3
>>
>>   CFLAGS+=-I${.CURDIR}/../../../../sys
>      I think it's actually safe to bump it to WARNS = 6 if you define
> NO_WCAST_ALIGN = 1, but that would need to be tested.
And the code in question needs to be audited to make sure that the 
alignment changes are benign.  Blindly setting this just papers over the 
bugs...

Warner
> Cheers,
> -Garrett
>
>
>