From owner-cvs-src@FreeBSD.ORG  Wed Jan 14 21:19:37 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 432F116A4CE; Wed, 14 Jan 2004 21:19:37 -0800 (PST)
Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4BB8743D41; Wed, 14 Jan 2004 21:19:36 -0800 (PST)
	(envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.12.9p2/8.12.9) with ESMTP id i0F5JO7E041440;
	Wed, 14 Jan 2004 21:19:28 -0800 (PST)
	(envelope-from truckman@FreeBSD.org)
Message-Id: <200401150519.i0F5JO7E041440@gw.catspoiler.org>
Date: Wed, 14 Jan 2004 21:19:24 -0800 (PST)
From: Don Lewis <truckman@FreeBSD.org>
To: jroberson@chesapeake.net
In-Reply-To: <20040114224559.K36463-100000@mail.chesapeake.net>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/compat/linux linux_util.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jan 2004 05:19:37 -0000

On 14 Jan, Jeff Roberson wrote:
> On Wed, 14 Jan 2004, Don Lewis wrote:
> 
>> truckman    2004/01/14 14:38:03 PST
>>
>>   FreeBSD src repository
>>
>>   Modified files:
>>     sys/compat/linux     linux_util.c
>>   Log:
>>   VOP_GETATTR() wants the vnode passed to it to be locked.  Instead
>>   of adding the code to lock and unlock the vnodes and taking care
>>   to avoid deadlock, simplify linux_emul_convpath() by comparing the
>>   vnode pointers directly instead of comparing their va_fsid and
>>   va_fileid attributes.  This allows the removal of the calls to
>>   VOP_GETATTR().
> 
> I'm not sure that the vnode pointer compare works in the case of device
> aliasing.  Any comments?

I believe you are correct, though one would hope that /compat/linux
wasn't a device.  The va_fsid and va_fileid test would not work either.
For devices you want to look at va_rdev.