From owner-freebsd-hackers@freebsd.org  Fri Feb 22 10:10:33 2019
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C300D14E4CDA
 for <freebsd-hackers@mailman.ysv.freebsd.org>;
 Fri, 22 Feb 2019 10:10:33 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0F16E8D4EF
 for <freebsd-hackers@freebsd.org>; Fri, 22 Feb 2019 10:10:32 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x1MAAQYO087713
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Fri, 22 Feb 2019 12:10:29 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x1MAAQYO087713
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id x1MAAQYK087712;
 Fri, 22 Feb 2019 12:10:26 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Fri, 22 Feb 2019 12:10:26 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Robert Ayrapetyan <robert.ayrapetyan@gmail.com>
Cc: FreeBSD <freebsd-hackers@freebsd.org>
Subject: Re: ptrace: SIGTRAP and EXIT race
Message-ID: <20190222101026.GX2420@kib.kiev.ua>
References: <CAAboi9tT==FFXdqq9XG2v8Lxf8RBuTMx5ns4puZ-hjD5KecFsA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAAboi9tT==FFXdqq9XG2v8Lxf8RBuTMx5ns4puZ-hjD5KecFsA@mail.gmail.com>
User-Agent: Mutt/1.11.2 (2019-01-07)
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM,
 NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Feb 2019 10:10:33 -0000

On Thu, Feb 21, 2019 at 08:43:20PM -0800, Robert Ayrapetyan wrote:
> Hello.
> 
> Before creating a bug and providing some test code, would ask a community
> here.
> When tracing a process using ptrace and there are multiple threads in the
> tracing process hitting the same breakpoint, sometimes main thread exits
> (WIFEXITED(status) is TRUE) before last queued TRAP_BKPT signal(s) have
> been delivered to the tracing process. So a final breakpoint hits counter
> is less than it should be.
> 
> So in the example below:
> 
> #include <iostream>
> #include <thread>
> 
> #include <pthread_np.h>
> 
> static const int num_threads = 2;
> 
> void foo() {
>     for (int i = 0; i < 2; ++i) {
>         printf("hi: %d (tid: %d)\n", i, pthread_getthreadid_np());
>     }
> }
> 
> int main() {
>     std::thread t[num_threads];
> 
>     for (int i = 0; i < num_threads; ++i) {
>         t[i] = std::thread(foo);
>     }
> 
>     for (int i = 0; i < num_threads; ++i) {
>         t[i].join();
>     }
> 
>     return 0;
> }
> 
> If we set breakpoint to printf, it should be triggered 4 times (tracing
> process should receive TRAP_BKPT 4 times). However, in ~1 of 5 runs, it
> receives TRAP_BKPT just 2 or 3 times.
> 
> Is this expected? Thanks.

I indeed would expect that all four breakpoints triggered before the
main thread exits, assuming that the breakpoints were installed before
the threads are created.  Please provide the stand-alone (and preferrably
non-interactive) test to reproduce the issue.