Date: Fri, 30 Mar 2012 20:35:45 +0000 From: "Philip M. Gollucci" <pgollucci@gmail.com> To: Michael Scheidell <scheidell@freebsd.org> Cc: freebsd-ports@freebsd.org Subject: Re: FAQ on PORTREVISION bump? Message-ID: <4F761921.7030505@p6m7g8.com> In-Reply-To: <4F760FB3.6020708@FreeBSD.org> References: <4F732C89.3040804@FreeBSD.org> <CADLo838kts0QhA1Rvf=S-GCZK2quyfmUdJHUqn6J2-31F9aWXQ@mail.gmail.com> <4F733432.4020902@FreeBSD.org> <63ca1b333a310ecc2b1d1f0e1e1542a1.squirrel@mail.experts-exchange.com> <4F7338C3.8020003@p6m7g8.com> <4F733C3A.7020004@missouri.edu> <4F734524.2000400@p6m7g8.com> <4F735340.1020103@FreeBSD.org> <4F7379FD.9040802@p6m7g8.com> <20120329200243.GA76833@server.vk2pj.dyndns.org> <20120330131625.GA30070@atarininja.org> <4F75F3ED.9000508@p6m7g8.com> <4F75FA31.2030806@p6m7g8.com> <4F760FB3.6020708@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig33DDD0DDD6A1308C9AE872D0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
On 03/30/12 19:55, Michael Scheidell wrote:
>=20
> * Mandatory:
> o When package changes (make package)
yes. Lets call this #1
> o When dependencies change (Adding USE_PERL/BUILD_PERL/GETTEXT=
> counts)
#1 covers this.
> o When pkg-plist changes (except for fixing
> .ifdef/NOPORT(DOCS|EXAMPLES))
#1 covers this, this is the OPTIONS case (default vs not)
> o When the master port changes
#1 covers this
> o When PORTVERSION CHANGES (must change back to 0, delete line=
)
#1 covers this.
> o When you want to force a relink with an updated (fixed) libr=
ary
#1 covers this. This is in the library port itself. The dependencies
figure this out.
> o If a patch fixes something in the port
#1 covers this.
> o If you add new functionality
#1 covers this.
> o If you add/delete an OPTION
#1 covers this. (default vs not default OPTIONS). If you count the end
user it doesn't matter if its off by default.
> o If you change the default for an OPTION
#1 covers this.
> * port committers have authority to bump PORTREVISION maintainer
> (implicit) if the master port/library port/dependency port
> requires any dependency to fit the list above.
not really relevant.
* just fixing .ifdef/NOPORT(DOCS|EXAMPLES))
sure is relevant see above
* if port was broken on any arch. (rebuilding on existing arch is a
noop, and fixed arch didn't package anyway)
removing IGNORE,BROKEN do not require this b/c there was previously no
package.
* Fixing typo's in pkg-message, Comment
Yes, the package changes, but no the functionality doesn't, so this is
correct.
* Updating port maintainer (new one or resetting port maintainer)
Correct.
* just petting portlint (<space> after name to <tab>), re-order sectio=
ns
Correct.
In short what you change is irrelevant. Does the resultant package
change. Yes or No. The only question you need to answer is do we bump
if the resultant package changes for configs other than default.
--=20
------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
Member, Apache Software Foundation
Committer, FreeBSD Foundation
Consultant, P6M7G8 Inc.
Director Operations, Ridecharge Inc.
Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.
--------------enig33DDD0DDD6A1308C9AE872D0
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iD8DBQFPdhkjdbiP+9ubjBwRAsJaAJ0XHN9dxeOY9WWlm3IUvTbGN0RAYACgkmFw
irWrVI40p6O1ervMx3aUVIY=
=MinF
-----END PGP SIGNATURE-----
--------------enig33DDD0DDD6A1308C9AE872D0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F761921.7030505>