Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Jun 2020 09:11:47 +0200
From:      Sergio Carlavilla <carlavilla@freebsd.org>
To:        Hiroki Sato <hrs@freebsd.org>
Cc:        bcr@freebsd.org, doc-committers@freebsd.org, svn-doc-all@freebsd.org,  svn-doc-head@freebsd.org
Subject:   Re: svn commit: r54297 - head/en_US.ISO8859-1/articles/freebsd-update-server
Message-ID:  <CAFwocyOs%2BoXxMxzGc7xQ=xBJhq9H=t%2BfrJ_3oG6r11UYw7Qnjg@mail.gmail.com>
In-Reply-To: <20200628.090036.537615336548910026.hrs@FreeBSD.org>
References:  <202006271723.05RHNAUm086528@repo.freebsd.org> <20200628.090036.537615336548910026.hrs@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 28 Jun 2020 at 02:01, Hiroki Sato <hrs@freebsd.org> wrote:
>
> Sergio Carlavilla Delgado <carlavilla@FreeBSD.org> wrote
>   in <202006271723.05RHNAUm086528@repo.freebsd.org>:
>
> ca> Author: carlavilla
> ca> Date: Sat Jun 27 17:23:09 2020
> ca> New Revision: 54297
> ca> URL: https://svnweb.freebsd.org/changeset/doc/54297
> ca>
> ca> Log:
> ca>   Because of the conversion of the documentation to Hugo/AsciiDoctor the
> ca>   screen was moved out of the callout.
> ca>
> ca>   Reviewed by:      bcr@
> ca>   Differential Revision:    https://reviews.freebsd.org/D25485
> ca>
> ca> Modified:
> ca>   head/en_US.ISO8859-1/articles/freebsd-update-server/article.xml
> ca>
> ca> Modified: head/en_US.ISO8859-1/articles/freebsd-update-server/article.xml
> ca> ==============================================================================
> ca> --- head/en_US.ISO8859-1/articles/freebsd-update-server/article.xml Fri Jun 26 07:04:58 2020        (r54296)
> ca> +++ head/en_US.ISO8859-1/articles/freebsd-update-server/article.xml Sat Jun 27 17:23:09 2020        (r54297)
> ca> @@ -267,10 +267,9 @@ export EOL=1275289200<co xml:id="eol-id"/></programlis
> ca>           <literal>EOL</literal> can be derived from the date
> ca>           listed on the web site, using the &man.date.1; utility,
> ca>           for example:</para>
> ca> -
> ca> -     <screen>&prompt.user; <userinput>date -j -f '%Y%m%d-%H%M%S' '20090401-000000' '+%s'</userinput></screen>
> ca>       </callout>
> ca>     </calloutlist>
> ca> +   <screen>&prompt.user; <userinput>date -j -f '%Y%m%d-%H%M%S' '20090401-000000' '+%s'</userinput></screen>
> ca>        </step>
> ca>      </procedure>
> ca>    </sect1>
>
>  Please revert this or explain why this is required.  The original
>  structure was valid and the callout list after this change become
>  wrong.  The <screen> element must be associated to the second
>  <callout>.
>
> -- Hiroki

Hi Hiroki,

First of all, thanks for taking time to check my change :)

I made this change because it made the migration to hugo/asciidoctor
much easier, but I don't want to cause any problem.

I reverted the change, sorry for the inconvenience.

Bye, and again, thanks for taking time to check this.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFwocyOs%2BoXxMxzGc7xQ=xBJhq9H=t%2BfrJ_3oG6r11UYw7Qnjg>