From owner-freebsd-ports@FreeBSD.ORG Tue Feb 8 19:34:28 2005 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C030A16A4CE for ; Tue, 8 Feb 2005 19:34:28 +0000 (GMT) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id B2B2643D55 for ; Tue, 8 Feb 2005 19:34:27 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.12.9p2/8.12.9) with ESMTP id j18JXAnZ043620; Tue, 8 Feb 2005 22:34:25 +0300 (MSK) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.12.9p2/8.12.9/Submit) id j18JX7OS043614; Tue, 8 Feb 2005 22:33:07 +0300 (MSK) (envelope-from yar) Date: Tue, 8 Feb 2005 22:33:07 +0300 From: Yar Tikhiy To: Florent Thoumie Message-ID: <20050208193307.GB43153@comp.chem.msu.su> References: <42075175.20603@ntmk.ru> <20050207125420.GA85693@heechee.tobez.org> <20050207154456.GB65425@comp.chem.msu.su> <420794CC.1070604@xbsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <420794CC.1070604@xbsd.org> User-Agent: Mutt/1.5.6i cc: Boris Kovalenko cc: freebsd-ports@freebsd.org Subject: Re: We need new feature for pkg_create? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2005 19:34:28 -0000 On Mon, Feb 07, 2005 at 05:18:20PM +0100, Florent Thoumie wrote: > > > >IMHO, what we need is a way to restore the initial prefix setting > >in a packing list. The idea of @pushwd and @popwd looks really > >neat to me. With those commands available, it would be possible > >to append lines using %D or just assuming the current prefix is the > >right one to the final packing list from bsd.port.mk without breaking > >"pkg_add -p /foo". > > > >BTW, here's an example that the problem is rather general. Currently > >using @cwd in port's pkg-plist and PORTDOCS in its Makefile results > >precisely in broken "pkg_add -p /foo" because the build-time prefix > >gets hardcoded in the packing list. > > I don't like the idea of a "working directory" stack because at > most, you'll push one time (or your port is behaving weirdly). This makes sense to me. > FWIW, I just sent a PR with a patch to address this issue [1]. > Feel free to add comments in the audit trail. > > [1] http://www.freebsd.org/cgi/query-pr.cgi?pr=77212 /usr/src/MAINTAINERS lists eik@freebsd.org as the maintainer of src/usr.sbin/pkg_install. IMHO it should be reasonable to draw his attention to your PR. -- Yar