From owner-cvs-src@FreeBSD.ORG Wed May 7 22:32:41 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E122106564A; Wed, 7 May 2008 22:32:41 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk1.360sip.com [72.236.70.240]) by mx1.freebsd.org (Postfix) with ESMTP id 692D48FC24; Wed, 7 May 2008 22:32:40 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.0.36] ([204.244.149.125]) (authenticated bits=0) by sippysoft.com (8.13.8/8.13.8) with ESMTP id m47M4mdW069329 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 7 May 2008 15:04:50 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Message-ID: <48222782.7000303@FreeBSD.org> Date: Wed, 07 May 2008 15:04:50 -0700 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) MIME-Version: 1.0 To: Alfred Perlstein References: <200805051603.m45G3rrN089219@repoman.freebsd.org> <200805051459.29200.jhb@freebsd.org> <20080505192417.GS7293@server.vk2pj.dyndns.org> <200805051637.43073.jhb@freebsd.org> <20080507064013.GU32532@elvis.mu.org> In-Reply-To: <20080507064013.GU32532@elvis.mu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Peter Jeremy , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, John Baldwin , cvs-src@FreeBSD.org Subject: Re: cvs commit: src/include stdio.h src/lib/libc/stdio clrerr.c feof.c ferror.c fileno.c getc.c getchar.c local.h putc.c putchar.c xprintf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 May 2008 22:32:41 -0000 Alfred Perlstein wrote: >> It appears that autoconf only believes a type is real if you can typedef it to >> another type, cast 0 to a valid pointer to the new typedef'd type, and do a >> sizeof() of the typdef'd type. The last is where having an opaque type >> breaks down for scripts that want to make sure FILE is a real type. > > > Oh c'mon! we're going to revert this needed fix just because of > autoconf? > > By the time 8.0 rolls around, autoconf will be fixed and there > will be some standard patch/workaround for old autoconf. > > Let's just roll forward with this. We've needed it for years. Can you please explain the "needed" part? What are gains apart from pure aesthetics and removing some type dependency from libc that otherwise needs to know actual storage type of pthread_t&Co? Neither is worth breaking zillion autoconf scripts out there IMHO (not everybody uses up to date ports and ports in general!). -Maxim