From owner-cvs-all@FreeBSD.ORG Mon Nov 21 18:20:42 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 91DC416A41F; Mon, 21 Nov 2005 18:20:42 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id B30EA43DA9; Mon, 21 Nov 2005 18:20:16 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id jALIK4dm021590; Mon, 21 Nov 2005 11:20:05 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <43820FD4.90902@samsco.org> Date: Mon, 21 Nov 2005 11:20:04 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050416 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <20051119165547.0A4BD16A43D@hub.freebsd.org> <4381FEDF.7080607@root.org> <00ff01c5eec3$3b0e6640$0300a8c0@COMETE> <200511211316.56666.jhb@freebsd.org> In-Reply-To: <200511211316.56666.jhb@freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, Damien Bergamini , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Nate Lawson Subject: Re: cvs commit: src/sys/modules/iwi Makefile src/sys/dev/iwi if_iwi.c if_iwireg.h if_iwivar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2005 18:20:42 -0000 John Baldwin wrote: > On Monday 21 November 2005 12:44 pm, Damien Bergamini wrote: > >>I don't like the idea of keeping the firmware in kernel memory. >>It's a rather big file (~200KB). >>And there is one for each operating mode (BSS, IBSS, monitor). >> >>The second reason why I don't like KLDs is because they require >>user intervention and users must know which KLD to load for the >>mode they want to operate in. And if you put all firmwares in >>the same KLD, you end up with a big fat 1MB file. >> >>I won't go back to anything based on iwicontrol. People simply >>don't know how to use it. Trust me. There is not a single day >>where I don't get email from people complaining about it. > > > Whatever logic you are doing in the kernel now to figure out which firmware to > use you can just as easily do in the kerenl and trigger it by sending a devd > event. You could have the userland side do an ioctl to get the type of > firmware the driver wants for example. There is _ZERO_ reason that you have > to do this in the kernel. You can move this logic out to userland and be > much more robust in the process. As it is, trying to do VOP_READ() in the > resume path is going to greatly diminish the robustness of suspend/resume. > Moving this to userland is not a hard problem. > As Nate asked, please move this to arch@ Scott