From owner-freebsd-bugs@FreeBSD.ORG  Mon Sep 13 01:20:24 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4245316A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 13 Sep 2004 01:20:24 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 34F1A43D4C
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 13 Sep 2004 01:20:24 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8D1KOHh061777
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 13 Sep 2004 01:20:24 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8D1KOCf061776;
	Mon, 13 Sep 2004 01:20:24 GMT
	(envelope-from gnats)
Date: Mon, 13 Sep 2004 01:20:24 GMT
Message-Id: <200409130120.i8D1KOCf061776@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Dan Lukes <dan@obluda.cz>
Subject: Re: bin/71631: [PATCH] cleanup of the usr.sbin/pppctl code
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Dan Lukes <dan@obluda.cz>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Sep 2004 01:20:24 -0000

The following reply was made to PR bin/71631; it has been noted by GNATS.

From: Dan Lukes <dan@obluda.cz>
To: Giorgos Keramidas <keramida@freebsd.org>
Cc: bug-followup@freebsd.org
Subject: Re: bin/71631: [PATCH] cleanup of the usr.sbin/pppctl code
Date: Mon, 13 Sep 2004 03:11:47 +0200 (CEST)

 On Sun, 12 Sep 2004, Giorgos Keramidas wrote:
 
 >> -     int n, arg, fd, len, verbose, save_errno, hide1, hide1off, hide2;
 >> +     int n, arg, len, verbose, save_errno, hide1, hide1off, hide2;
 >> +     int fd = fd;	/* init to avoid "might be used unitialized" warning 8/
 >
 > fd = -1; would be a better initialization, since no valid descriptor can
 > ever be negative and this will expose any bugs that using fd before a
 > proper initialization can trigger.
 
  	But unnecesarry over-initialisation is waste of resources.
 
  	It's about decision ...
 
  	I have no opinion which is better (generally).