From nobody Mon Apr 27 18:36:38 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g4C2l2gBtz6bSFL; Mon, 27 Apr 2026 18:36:47 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from mx0b-00273201.pphosted.com (mx0a-00273201.pphosted.com [208.84.65.16]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.pphosted.com", Issuer "Sectigo Public Server Authentication CA OV R36" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g4C2l1K0Gz42f6; Mon, 27 Apr 2026 18:36:47 +0000 (UTC) (envelope-from sjg@juniper.net) Authentication-Results: mx1.freebsd.org; none Received: from pps.filterd (m0108157.ppops.net [127.0.0.1]) by mx0a-00273201.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63RI0Lew177895; Mon, 27 Apr 2026 11:36:45 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=PPS03102026; bh=K/2iAfIlyg8Xr55CFYBaduXQ1eNnoMCWaoSd2KZbieg=; b=JyP5CnIQeYqi 5na1HFtrDfKCxhkQbde3plRs/POgzr/CMjkTv9S8SrrtnCjwMqvxyLyvRLblCxto rfKZ/s/ZZG0sZK6z0zhEpgdO17VKiNsZlJ8ZlZCSO0sNIsdph3LWQJc4gB48wPsO HPr5Rvas8eXcXpI6htl8BuRjaFC6GES5vMEeuAGiXnNHsO5dP+uEn2gQjQxiAkem PWt1aloyhvUBKMI7J6Thswk5dxP+BvDvHlc7F45H5JnNHHAlCnGHi4zMt54GGEHI sg2M2mP41SGJm8aGlOliLtVIc8CUlnJFN0Ptvsc9V6ZEi4qSOxP2YZRp+4nI4vBq ewuEVOBddQ== Received: from sn4pr2101cu001.outbound.protection.outlook.com (mail-southcentralusazon11012041.outbound.protection.outlook.com [40.93.195.41]) by mx0a-00273201.pphosted.com (PPS) with ESMTPS id 4dta5r8vdg-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 27 Apr 2026 11:36:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ExZiUZV6Aip/MoRsUU6YQoGGb4lVHex8fjEquMroYuIUg+q8Aqx1XWRorW0UJk+Zf2WFaWWPJ4NHKaaTAIhybz6Bhp+n2x8MKoMjP8B75Ll+niI1fQtVTlxX3Re0H3xmUyiVPdq8ESzp/+vQmpzH6aKb1+VBgQI7TGh84VZrX+NLqzgifslYpSicuYlHjjD008CgXr9ux34UmRKe5D/ejUNGvDIEG9vwTalv050nM8JYVK33jksk16Syd27zcfNnJkuuGXtiMMjsOKYdWSI/J3hgdNUD2rLNWBsMmNKh8YvyFlEvOEOqaDSN3/j5uWmi47mp5HAYSqv42n300Dui+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K/2iAfIlyg8Xr55CFYBaduXQ1eNnoMCWaoSd2KZbieg=; b=aGXU4MieG9qyDZoIJHnPLZB7vwP/PanTQR/jkKxNecsw8FQSLAn5gIVSBOh4i1m3HKqJpKQsDUowxJug8I6mmC/omzLGj6FPl40zQNsfpj554WYb98Jnrk9PHFO5iC2SUPruBcHwa0w0FCxidBPtgVFaGn4lju0ftZN6HjRAQQY1TNakbeAWUhoX3gTDhrF+1sC71Rr7A+OpJeIKnfTP5jwXEzrlKI06ukOnqjwYy1CnoL9pWDOszRtDKxgvADGaX1g6LcRqm+Wm4QqCu7YSmJ3C+xHREYyLoAwINwhTGavaJFpsXVR+CQBgo/TreGhkzkAZ9YzQicJkOFZDr8doVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 66.129.239.14) smtp.rcpttodomain=freebsd.org smtp.mailfrom=juniper.net; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=juniper.net; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K/2iAfIlyg8Xr55CFYBaduXQ1eNnoMCWaoSd2KZbieg=; b=OCb3I3B1QJ/9Z7NJT0Qf0iVhrrBaxUgxtYvaL7oSIiSkWP5KU1BQxqSi3xXGPjs+I6yatmDzOoarpCK1+foH2xBd1edUEXT61fYWkCrMTh3f007RUgq+v444kpsP2h3YnUxQ93quHQkpHButFuGSgUuBJHfM+DQwobvA9r22K2Y= Received: from BN9PR03CA0307.namprd03.prod.outlook.com (2603:10b6:408:112::12) by BY3PR05MB8387.namprd05.prod.outlook.com (2603:10b6:a03:3c6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.26; Mon, 27 Apr 2026 18:36:40 +0000 Received: from BN2PEPF000055DC.namprd21.prod.outlook.com (2603:10b6:408:112:cafe::8a) by BN9PR03CA0307.outlook.office365.com (2603:10b6:408:112::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.26 via Frontend Transport; Mon, 27 Apr 2026 18:36:40 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 66.129.239.14) smtp.mailfrom=juniper.net; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=juniper.net; Received-SPF: Fail (protection.outlook.com: domain of juniper.net does not designate 66.129.239.14 as permitted sender) receiver=protection.outlook.com; client-ip=66.129.239.14; helo=juniper.net; Received: from juniper.net (66.129.239.14) by BN2PEPF000055DC.mail.protection.outlook.com (10.167.245.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.0 via Frontend Transport; Mon, 27 Apr 2026 18:36:39 +0000 Received: from p-exchbe-eqx-03.jnpr.net (10.104.9.86) by p-exchfe-eqx-04.jnpr.net (10.104.9.52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 27 Apr 2026 11:36:39 -0700 Received: from p-exchbe-eqx-04.jnpr.net (10.104.9.87) by p-exchbe-eqx-03.jnpr.net (10.104.9.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 27 Apr 2026 11:36:38 -0700 Received: from kaos.jnpr.net (10.104.20.6) by p-exchbe-eqx-04.jnpr.net (10.104.9.87) with Microsoft SMTP Server id 15.2.2562.37 via Frontend Transport; Mon, 27 Apr 2026 11:36:38 -0700 Received: by kaos.jnpr.net (Postfix, from userid 1377) id AECD1C6727; Mon, 27 Apr 2026 11:36:38 -0700 (PDT) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id ABA6FC6882; Mon, 27 Apr 2026 11:36:38 -0700 (PDT) To: =?us-ascii?Q?=3D=3Futf-8=3FQ=3FDag-Erling=5FSm=3DC3=3DB8rgrav=3F=3D?= CC: , , , Subject: Re: git: 566cc005812b - main - safe_set treat ':' and '#' differently In-Reply-To: <86bjf41chq.fsf@ltc.des.dev> References: <69e8f964.39869.24418b55@gitrepo.freebsd.org> <86jyts1xzr.fsf@ltc.des.dev> <15177.1777314263@kaos.jnpr.net> <86bjf41chq.fsf@ltc.des.dev> Comments: In-reply-to: =?us-ascii?Q?=3D=3Futf-8=3FQ=3FDag-Erling=5FSm=3DC3?= =?us-ascii?Q?=3DB8rgrav=3F=3D?= message dated "Mon, 27 Apr 2026 20:31:29 +0200." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6+git; nmh 1.8; Emacs 30.2 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Mon, 27 Apr 2026 11:36:38 -0700 Message-ID: <24831.1777314998@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055DC:EE_|BY3PR05MB8387:EE_ X-MS-Office365-Filtering-Correlation-Id: bbd38d19-8e45-475c-dd86-08dea48bebee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|1800799024|376014|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: GCXSDqQlNlD2ErYoNGvcOKbXn/n9/r3S8aAjrs1yg5WMMJlIsfBXDp2M1QZyMXLURaeO+9CcBsmOpgcsojk/PGkXx4LDwwK/WJiNi2F60P1el0xwgEyIMURQJhiXWa3dvJAsjC4Auj/YbxVjfb/8uCO4LydkZFnXFS7Nx0JwZQfhZ/WqxswSiVbruaj3ezt/3Hk3pdZVnCIR9s7ZKD1TGfktrNXwwqsG/3vRWJhK3bOuumP9LsqedMJbaVxHmBPD8X5FsZXfU3Cnhj6vgPQa0bLYryG5Qo5eMBrvxLe1d+0ECSQ9R0jpirKS7mMeW6Oew4tk95VUPzXWiTCePfotYXuUaQdgEwtdTl2VQXwrg7fE/It/CoIMeszpdJWd/DpAS604GIQyjbcNdhH3bJ61s69PIluUoDV0qiVp6fY16QFqwxPhCjKPcKAC1Id+HkVBHRuFgozWVWPpwZpG8FogbSprF36R3ae+WSf6OP3aHXv59Lkhhtp5Gxoj87tdTNLzVvS0BFWG2aaiIzQ+6l45QwsqipAHvMJ3KF0P+0VPIT+U8/nibz2P2+WMHFHvpeo1LofFTa+jjW3TE6Cci3QD5mN23A7ef1ZedabVhAyo4U+xmIRL9cTXLHzgcoZx0//wF3t9CFelhkTZKLS1b1Qdn9+uKD1+vWIyQ8bgN3PNBDPpIA4f1XbpH4qufgfO+uwAtJwPmDKClznLTPg81RLjYQtEicRAZTRnMgMJ6eiYHMHG0JAz+mfDXUCHsIALtHW8HtXytDUA3lgJ5sOKPGi5aA== X-Forefront-Antispam-Report: CIP:66.129.239.14;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:juniper.net;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(1800799024)(376014)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5JNPzBS/eqT4MD4pp+GYxhksqT2nk3F5DEC75jiWgKncdXqkQrmZfYLyTUTD4dcoUfzhjAr3boIWPY1xRgtl2OFWxcpBFuYuRYFfG3JrxDkZaPwfbYY8o6tEQhKVE2g31ZImTXCHexiK0kBss+rXez2OEJGpt+YWVOxHBdkHBt167vEihKGSBuwWRLh8/9srRDsEZLAz3kzAfAWAw8efdfXc0satCv6p0TvxMp8i3h1t2ewCr/ilM8IMfHJt4Q/w5y6dAxa9kY5bXACPueIkPqmnWM0T0ZtDuyv4tsQ6pT2EeghAu52rzu7Avk4/X9bjT3wmDA6RIfghkmvr5I7lo8QZIvHWUxQs85MEevlXCe5cng3RLUhMtWMPUeposUOGtQe/2BwXscOk4/sblryE2F04wNwFQuJcQQ0GHevHsYX75gJTMzTkVuEwO/H8ixQr X-Exchange-RoutingPolicyChecked: X07ZuRwRzb0xPHTP3j+EmYC7NndfcSsNp9X+pC2xjotWF+cloEdVwD2cbCbRsgff0ceISwjqv37+Wj/cI5BQcu5LehLiBo2AM6N/ICv3BxLJUdi5XrFJ7RsKoXRS5xZKa+xmbozWVE7/K2rb5tTQQKXsqBbjvNl3YihUt7ac6BotAha9UOPDu/NSDb0pOYBOn0cktS8TVi0HXzIBaLFKZ0IG7FvZlfy+oyUV+IA3SMfgmFfYT0U955lmehOg+wBnvtGaO7f/tPufo8wBORuppHcIC7cOyrctjc1scz4qlkc52e6zZj0q66WRoG0pTegeCFQOCJaqsg4gMKzd7Ohj/A== X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 18:36:39.7427 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bbd38d19-8e45-475c-dd86-08dea48bebee X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4;Ip=[66.129.239.14];Helo=[juniper.net] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055DC.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR05MB8387 X-Proofpoint-ORIG-GUID: khoNbznT-nw8PLss10ONtk8RrS-DZahg X-Authority-Analysis: v=2.4 cv=C9vZDwP+ c=1 sm=1 tr=0 ts=69efacbd cx=c_pps a=9jlK8eo7xmF8zH0m+f/LEA==:117 a=f/rncuQqEjTEF/G1odkJ9w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s63m1ICgrNkA:10 a=rhJc5-LppCAA:10 a=VkNPw1HP01LnGYTKEx00:22 a=7vL3O5uBSuztJ3xaqtyr:22 a=O1S9G-DnkxobS-ZkPuRe:22 a=6I5d2MoRAAAA:8 a=5zyAEg4KNuEpZcpAOOYA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI3MDE5OSBTYWx0ZWRfXyaPwV9TxSVIC wHuRycDG/TkGVAludbwCIX6wg0XmKDUR/H0wIGn9VnAoS2H4ScpG5tphSxHDutCwwAbZ/5atPVf P865ezQPwsjtoak11/pHd+5cN1bwfTo+W4HcZ3G4068u6BCaRpqQ9STuG9V4oA6kEjTOhjkV+E0 QUqGEQhyf1IEBI9TjsTmc3vSkdpnmJi8HgduF3+sSOx/anzi+WbTMYF3NqLL2RkS4cvSSllxQz3 3Wnx9hEq39mTQUVaFJdCEZDEX3wxj5PXSHnCMpW7TZNlnQdKWQWFs6Em5cEuvarlw9DFWTcc6W2 ocuhJxS1bAmpr9nvPwyu2XsM24P6nsJWymKVi6Dypf6CokW7VzsiGtJ6mzH+3oJrHBcn2W2A5X3 SVSoWwR6STyAc++4HNPi7Rkwf2lyWlsMsesRHRkkzuZvgARFyKJxbhq1jb5R9ih22bfyr9vHU8Q De7YVcz0gsD2IJaMeLw== X-Proofpoint-GUID: khoNbznT-nw8PLss10ONtk8RrS-DZahg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-27_04,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604270199 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:26211, ipnet:208.84.65.0/24, country:US] X-Rspamd-Queue-Id: 4g4C2l1K0Gz42f6 X-Spamd-Bar: ---- Dag-Erling Sm=C3=B8rgrav wrote: > > The goal here is to ensure a line like that will be ignored. >=20 > That's beside the point, which is that your regex is incorrect. It will > treat e.g. `:foo` as a comment. Which is fine by me. That is not a syntax one commonly expects to see in rc.conf.d/* safe_eval is used it sitations where we are paranoid, normally only wanting to read *verified* input, but there are exceptions to every rule, and the goal of safe_set is to ensure nothing wicked gets eval'd. So I don't mind rejecting :foo=3Dbar