From owner-svn-src-head@freebsd.org Tue Jul 14 15:31:16 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E7095366ADC; Tue, 14 Jul 2020 15:31:16 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B5kxw3WTSz3ZJj; Tue, 14 Jul 2020 15:31:16 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-qk1-f193.google.com with SMTP id q198so15943753qka.2; Tue, 14 Jul 2020 08:31:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BxEi0GXaPo3VWjAjS5PH7zKcdK8/w1+i79oRPpY33W4=; b=MIt3jdpDLi5xobDAYM1sP3xuoOOxBc6Y1v82lemK3A54Y1I824cZqbDetDRxv2c8jf ZGQhaSf8UTelLZmz0p2QltwKKnVeyW1oQ36AQsqyEFuuWepzaan+ynui7ZpVd+Y4FphI UkJkDARwt650V1y8ebn4nQgS/jNLJhGovcrcP57KN1CElwyLWin+klepHQQlZYcZLNVw jMGKTqcXygGA3N2iixpUuFsIPJsHaUbK5KHdQCVWA0MMg8/RMsvv9InY4O4VcWSPQqSB 7wbzHma33Spf0w+ANdwE3sFYuVNHYvvXlgoLtB5gSLrpitSHdluXCPa4tS+ttnqhthgc /qyw== X-Gm-Message-State: AOAM532AdZWEPnR3y5b9vZRnGphLgXu1+ZFDWHJjWSQb+v/qBDgEaETN QQpuxOnkAMhoNlLffEKCJfYxCmM+aDiMh+ZJIgi7ag== X-Google-Smtp-Source: ABdhPJziKv/P+JfWc4b+iqzkZ6z7r/X+YktAkIm1f+kTANfxiUI5V8V0vWLLHzEXKO0rWsow7vOS6E0YKDT73WibvpQ= X-Received: by 2002:a05:620a:40d:: with SMTP id 13mr4722609qkp.304.1594740674488; Tue, 14 Jul 2020 08:31:14 -0700 (PDT) MIME-Version: 1.0 References: <202007140500.06E508mV016928@repo.freebsd.org> <953fd975-215b-2d53-23e6-58faa6af9c96@FreeBSD.org> In-Reply-To: <953fd975-215b-2d53-23e6-58faa6af9c96@FreeBSD.org> From: Adrian Chadd Date: Tue, 14 Jul 2020 08:31:02 -0700 Message-ID: Subject: Re: svn commit: r363171 - head/contrib/flex/src To: Jung-uk Kim Cc: src-committers , svn-src-all , svn-src-head , Kyle Evans X-Rspamd-Queue-Id: 4B5kxw3WTSz3ZJj X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2020 15:31:17 -0000 Hi! On Tue, 14 Jul 2020 at 08:00, Jung-uk Kim wrote: > On 20. 7. 14., Adrian Chadd wrote: > > Author: adrian > > Date: Tue Jul 14 05:00:08 2020 > > New Revision: 363171 > > URL: https://svnweb.freebsd.org/changeset/base/363171 > > > > Log: > > [flex] Fix compilation issue under mips-gcc-6.4 > > > > This was triggering a pointer-losing-constness error. > > It was discussed in this ML. > > https://lists.freebsd.org/pipermail/svn-src-head/2020-June/137432.html > > kevans even filed an upstream pull request. > > https://github.com/westes/flex/pull/449 Oh good! > > > Why did you commit it without asking us? > Oh I'm sorry! I didn't realise you were already doing the work to get it fixed upstream. I just saw things broken when building my test wifi setups here at home and saw they were small fixes that could be submitted upstream. I'm personally not a huge fan of sitting on patches that fix builds/functionality whilst waiting for upstream - this was one of the many reasons for migrating from CVS to SVN in the long distant past! - so I figured it would be easy to commit. I'll make sure I ask around a little more next time! -adrian > Jung-uk Kim >