From owner-freebsd-current@FreeBSD.ORG Mon Jun 7 19:29:20 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 2B1F116A4CE; Mon, 7 Jun 2004 19:29:20 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.12.11/8.12.11) with ESMTP id i57JTJWo020870; Mon, 7 Jun 2004 15:29:19 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.12.11/8.12.11/Submit) id i57JTJ5N020869; Mon, 7 Jun 2004 15:29:19 -0400 (EDT) (envelope-from green) Date: Mon, 7 Jun 2004 15:29:18 -0400 From: Brian Feldman To: Stefan Ehmann Message-ID: <20040607192918.GA20308@green.homeunix.org> References: <1086511629.1509.13.camel@taxman> <20040607172431.GA19790@green.homeunix.org> <1086633425.1020.15.camel@taxman> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1086633425.1020.15.camel@taxman> User-Agent: Mutt/1.5.6i cc: rwatson@freebsd.org cc: current@freebsd.org Subject: Re: esd leaking file descriptors X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 19:29:20 -0000 On Mon, Jun 07, 2004 at 08:37:05PM +0200, Stefan Ehmann wrote: > On Mon, 2004-06-07 at 19:24, Brian Feldman wrote: > > On Sun, Jun 06, 2004 at 10:47:09AM +0200, Stefan Ehmann wrote: > > > When i run mpg321 -o esd foo.mp3 (or any other player that uses esd as > > > output) lsof shows an increasing number of open files. It increases at a > > > rate of about 50 files per second. System will run out of file > > > descriptor eventually. > > > > > Check if esd is encountering exceptional conditions with the ktrace > > facility. You will wnat to run esd with ktrace(1) and then use > > kdump(1) to view the log of system calls. The other PC probably > > also doesn't have the same hardware, so it's not so easy to see if > > it's just a bug in -CURRENT. > > I just tried a kernel from June, 1st: esd doesn't leak any file > descriptors. So it's definitely a CURRENT problem. > > I couldn't spot anything suspicous using ktrace (That is no notable > difference compared to the other machine). > > Here are two excerpts from kdump output that basically repeat all the > time: I see a lot of accept(2) there... I think it's a good possibility Robert accidentally broke accept[1]()'s error cleanup. It seems that the file is dropped but the fd is left sitting around in a half-allocated state. Many of those 'goto done;'s should be 'goto noconnection;'s, I believe. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\