From owner-freebsd-security@freebsd.org  Wed Nov  4 17:38:40 2015
Return-Path: <owner-freebsd-security@freebsd.org>
Delivered-To: freebsd-security@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id ABC81A26525
 for <freebsd-security@mailman.ysv.freebsd.org>;
 Wed,  4 Nov 2015 17:38:40 +0000 (UTC) (envelope-from dan@obluda.cz)
Received: from smtp1.ms.mff.cuni.cz (smtp1.ms.mff.cuni.cz
 [IPv6:2001:718:1e03:801::4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 47CCB1873
 for <freebsd-security@freebsd.org>; Wed,  4 Nov 2015 17:38:39 +0000 (UTC)
 (envelope-from dan@obluda.cz)
X-SubmittedBy: id 100000045929 subject
 /DC=org/DC=terena/DC=tcs/C=CZ/O=Charles+20University+20in+20Prague/CN=Dan+20Lukes+20100000045929+20332603
 issued by
 /C=NL/ST=Noord-Holland/L=Amsterdam/O=TERENA/CN=TERENA+20eScience+20Personal+20CA+203
 auth type TLS.MFF
Received: from [10.20.12.2] ([194.108.204.138]) (authenticated)
 by smtp1.ms.mff.cuni.cz (8.14.9/8.14.9) with ESMTP id tA4HcYn1044164
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=OK)
 for <freebsd-security@freebsd.org>; Wed, 4 Nov 2015 18:38:36 +0100 (CET)
 (envelope-from dan@obluda.cz)
Subject: Re: FreeBSD Security Advisory FreeBSD-SA-15:25.ntp [REVISED]
To: freebsd-security@freebsd.org
References: <20151104131449.2777E1ACB@freefall.freebsd.org>
From: Dan Lukes <dan@obluda.cz>
Message-ID: <563A429C.406@obluda.cz>
Date: Wed, 4 Nov 2015 18:38:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:41.0) Gecko/20100101
 Firefox/41.0 SeaMonkey/2.38
MIME-Version: 1.0
In-Reply-To: <20151104131449.2777E1ACB@freefall.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-security@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "Security issues \[members-only posting\]"
 <freebsd-security.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-security>, 
 <mailto:freebsd-security-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-security/>
List-Post: <mailto:freebsd-security@freebsd.org>
List-Help: <mailto:freebsd-security-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-security>, 
 <mailto:freebsd-security-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Nov 2015 17:38:40 -0000

Even after latest patch the NTP code still doesn't compile cleanly.

> ===> usr.sbin/ntp/libntp (all)
> /usr/src/usr.sbin/ntp/libntp/../../../contrib/ntp/libntp/authreadkeys.c:252:4: warning: format specifies type 'unsigned int' but the argument has type 'size_t'
>       (aka 'unsigned long') [-Wformat]
>                         nerr);
>                         ^~~~
> /usr/src/usr.sbin/ntp/libntp/../../../contrib/ntp/libntp/authreadkeys.c:257:4: warning: format specifies type 'unsigned int' but the argument has type 'unsigned long' [-Wformat]
>                         nerr - nerr_loglimit);
>                         ^~~~~~~~~~~~~~~~~~~~

Fortunately, it seems not to cause severe security issue.

Dan