Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 Oct 2004 17:48:48 +0200 (CEST)
From:      Stefan Walter <sw@gegenunendlich.de>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        kde@FreeBSD.org
Subject:   ports/73126: [PATCH] devel/kdesdk3: fix off-by-one with moving list items in Umbrello
Message-ID:  <20041025154848.D2CD53A45@kyuzo.dunkelkammer.void>
Resent-Message-ID: <200410251550.i9PFoP8H016189@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         73126
>Category:       ports
>Synopsis:       [PATCH] devel/kdesdk3: fix off-by-one with moving list items in Umbrello
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 25 15:50:25 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Stefan Walter
>Release:        FreeBSD 5.3-STABLE i386
>Organization:
Infinity Approximation Task Force
>Environment:
System: FreeBSD kyuzo.dunkelkammer.void 5.3-STABLE FreeBSD 5.3-STABLE #0: Sun Oct 24 12:54:09 CEST 2004 root@kyuzo.dunkelkammer.void:/usr/obj/usr/src/sys/KYUZO i386
>Description:
When changing the order of operations or attributes of a class, using the
dialog's down button changes the order of items in the dialog list correctly,
but moves the item in the class itself down two slots (i.e. one too far).
>How-To-Repeat:
Create a class with attributes and/or operations, then double-click on the
class to open its properties dialog. Choose 'operations' or 'attributes'.
Choose one of the attributes/operations and click on the 'down' arrow. The
chosen item will be moved down by one in the list, but two in the diagram.
>Fix:
The following patch fixes Umbrello's behaviour. Note that I haven't been able
to connect to http://webcvs.kde.org/ (all connections timed out so far), so I
don't know if this patch needs to be sent upstream, too, or if it's already
fixed there.

--- patch-umbrello:umbrello:dialogs:classifierlistpage.cpp begins here ---
--- umbrello/umbrello/dialogs/classifierlistpage.cpp.old	Mon Oct 25 16:09:31 2004
+++ umbrello/umbrello/dialogs/classifierlistpage.cpp	Mon Oct 25 16:09:56 2004
@@ -348,7 +348,7 @@
 	//now change around in the list
 	UMLClassifierListItem* currentAtt = getItemList().at( index );
 	takeClassifier(currentAtt);
-	addClassifier(currentAtt, index + 2);
+	addClassifier(currentAtt, index + 1);
 	slotClicked( item );
 }
 
--- patch-umbrello:umbrello:dialogs:classifierlistpage.cpp ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041025154848.D2CD53A45>