From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Oct 25 15:50:25 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8BD3A16A4CE for ; Mon, 25 Oct 2004 15:50:25 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6DD0143D31 for ; Mon, 25 Oct 2004 15:50:25 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i9PFoPse016190 for ; Mon, 25 Oct 2004 15:50:25 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i9PFoP8H016189; Mon, 25 Oct 2004 15:50:25 GMT (envelope-from gnats) Resent-Date: Mon, 25 Oct 2004 15:50:25 GMT Resent-Message-Id: <200410251550.i9PFoP8H016189@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stefan Walter Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8951916A4D1; Mon, 25 Oct 2004 15:48:53 +0000 (GMT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.190]) by mx1.FreeBSD.org (Postfix) with ESMTP id D7D9643D5A; Mon, 25 Oct 2004 15:48:52 +0000 (GMT) (envelope-from sw@gegenunendlich.de) Received: from [212.227.126.161] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1CM75X-0002WO-00; Mon, 25 Oct 2004 17:48:51 +0200 Received: from [80.142.216.140] (helo=kyuzo.dunkelkammer.void) (TLSv1:EDH-RSA-DES-CBC3-SHA:168) (Exim 3.35 #1) id 1CM75X-0002x9-00; Mon, 25 Oct 2004 17:48:51 +0200 Received: by kyuzo.dunkelkammer.void (Postfix, from userid 1002) id D2CD53A45; Mon, 25 Oct 2004 17:48:48 +0200 (CEST) Message-Id: <20041025154848.D2CD53A45@kyuzo.dunkelkammer.void> Date: Mon, 25 Oct 2004 17:48:48 +0200 (CEST) From: Stefan Walter To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: kde@FreeBSD.org Subject: ports/73126: [PATCH] devel/kdesdk3: fix off-by-one with moving list items in Umbrello X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Stefan Walter List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Oct 2004 15:50:25 -0000 >Number: 73126 >Category: ports >Synopsis: [PATCH] devel/kdesdk3: fix off-by-one with moving list items in Umbrello >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Oct 25 15:50:25 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Stefan Walter >Release: FreeBSD 5.3-STABLE i386 >Organization: Infinity Approximation Task Force >Environment: System: FreeBSD kyuzo.dunkelkammer.void 5.3-STABLE FreeBSD 5.3-STABLE #0: Sun Oct 24 12:54:09 CEST 2004 root@kyuzo.dunkelkammer.void:/usr/obj/usr/src/sys/KYUZO i386 >Description: When changing the order of operations or attributes of a class, using the dialog's down button changes the order of items in the dialog list correctly, but moves the item in the class itself down two slots (i.e. one too far). >How-To-Repeat: Create a class with attributes and/or operations, then double-click on the class to open its properties dialog. Choose 'operations' or 'attributes'. Choose one of the attributes/operations and click on the 'down' arrow. The chosen item will be moved down by one in the list, but two in the diagram. >Fix: The following patch fixes Umbrello's behaviour. Note that I haven't been able to connect to http://webcvs.kde.org/ (all connections timed out so far), so I don't know if this patch needs to be sent upstream, too, or if it's already fixed there. --- patch-umbrello:umbrello:dialogs:classifierlistpage.cpp begins here --- --- umbrello/umbrello/dialogs/classifierlistpage.cpp.old Mon Oct 25 16:09:31 2004 +++ umbrello/umbrello/dialogs/classifierlistpage.cpp Mon Oct 25 16:09:56 2004 @@ -348,7 +348,7 @@ //now change around in the list UMLClassifierListItem* currentAtt = getItemList().at( index ); takeClassifier(currentAtt); - addClassifier(currentAtt, index + 2); + addClassifier(currentAtt, index + 1); slotClicked( item ); } --- patch-umbrello:umbrello:dialogs:classifierlistpage.cpp ends here --- >Release-Note: >Audit-Trail: >Unformatted: