From owner-freebsd-current@FreeBSD.ORG Fri May 7 08:47:05 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0615F106566C for ; Fri, 7 May 2010 08:47:05 +0000 (UTC) (envelope-from jroberson@jroberson.net) Received: from mail-px0-f182.google.com (mail-px0-f182.google.com [209.85.212.182]) by mx1.freebsd.org (Postfix) with ESMTP id D4F7F8FC0A for ; Fri, 7 May 2010 08:47:04 +0000 (UTC) Received: by pxi20 with SMTP id 20so414624pxi.13 for ; Fri, 07 May 2010 01:47:04 -0700 (PDT) Received: by 10.141.23.12 with SMTP id a12mr7726825rvj.145.1273222024426; Fri, 07 May 2010 01:47:04 -0700 (PDT) Received: from [10.0.1.198] (udp022762uds.hawaiiantel.net [72.234.79.107]) by mx.google.com with ESMTPS id h11sm836054rvm.21.2010.05.07.01.47.03 (version=SSLv3 cipher=RC4-MD5); Fri, 07 May 2010 01:47:03 -0700 (PDT) Date: Thu, 6 May 2010 22:47:00 -1000 (HST) From: Jeff Roberson X-X-Sender: jroberson@desktop To: Fabien Thomas In-Reply-To: <70EFD2C3-9EA3-43D0-A1CE-9FC7FA49C50A@netasq.com> Message-ID: References: <4BDF2A4D.3030706@gmail.com> <493FBE07-D745-4DDE-B7EE-C41F626B1597@netasq.com> <70EFD2C3-9EA3-43D0-A1CE-9FC7FA49C50A@netasq.com> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-current@freebsd.org Subject: Re: SUJ deadlock X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2010 08:47:05 -0000 On Fri, 7 May 2010, Fabien Thomas wrote: > fixed/works a lot better for me. Thanks Fabien, I just committed this. Thanks everyone for the assistance finding bugs so far. Please let me know if you run into anything else. For now I don't know of any other than some feature/change requests for tunefs. Thanks, Jeff > >> Applied and restarted portupgrade. >> Will tell you tomorrow. >> >> Fabien >> >> Le 6 mai 2010 ? 00:54, Jeff Roberson a ?crit : >> >>> On Mon, 3 May 2010, Fabien Thomas wrote: >>> >>>>>> Hi Jeff, >>>>>> >>>>>> I'm with r207548 now and since some days i've system deadlock. >>>>>> It seems related to SUJ with process waiting on suspfs or ppwait. >>>>> >>>>> I've also seen it stalled in suspfs, but this information is way better >>>>> than what I was able to garner. I was only able to tell via ctrl-t on >>>>> a stalled 'ls' process in a terminal before hard booting. >>>>> >>>>> Right now it occurs everytime I attempt to do the portmaster -a upgrade >>>>> of X/KDE on this system. >>>> >>>> I've spotted this during multiple portupgrade -aR :) >>> >>> Can anyone who has experienced this hang test this patch: >>> >>> Thanks, >>> Jeff >>> >>> Index: ffs_softdep.c >>> =================================================================== >>> --- ffs_softdep.c (revision 207480) >>> +++ ffs_softdep.c (working copy) >>> @@ -9301,7 +9301,7 @@ >>> hadchanges = 1; >>> } >>> /* Leave this inodeblock dirty until it's in the list. */ >>> - if ((inodedep->id_state & (UNLINKED | DEPCOMPLETE)) == UNLINKED) >>> + if ((inodedep->id_state & (UNLINKED | UNLINKONLIST)) == UNLINKED) >>> hadchanges = 1; >>> /* >>> * If we had to rollback the inode allocation because of >>> >>> >>>> >>>> Fabien >>>> _______________________________________________ >>>> freebsd-current@freebsd.org mailing list >>>> http://lists.freebsd.org/mailman/listinfo/freebsd-current >>>> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >>>> >> >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >