From owner-freebsd-hackers@FreeBSD.ORG Fri Apr 1 16:13:28 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3F04B106566B; Fri, 1 Apr 2011 16:13:28 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-qy0-f182.google.com (mail-qy0-f182.google.com [209.85.216.182]) by mx1.freebsd.org (Postfix) with ESMTP id BA5B38FC1B; Fri, 1 Apr 2011 16:13:27 +0000 (UTC) Received: by qyk27 with SMTP id 27so2848801qyk.13 for ; Fri, 01 Apr 2011 09:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=CoiCaIkotaFwg0wZJn6x81lFimHxtfoP+ucP7lKfW4A=; b=PC9j63fsSXwCOZyRA47xmiBKZROMefV/UHO4E4Lj85J7j0f2aw7hompXmVQhhrRAb2 4Y6sMAr6SXVxWE0dn3WisQiHsC7cKsm60H3ZOFANhPLvYthXgLpbR+GWmrgEmyI6yKdR rZ0GAFDsVVL7OyCjSwA6xb35JL0JAKXa1DbEA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=Gg4vcXqIrs8qLMLLKg+/DiJ5trP6YAewUsy09K7QC+9NxmwsfbKS6mlolpMHORZoSs 64dtBhpjpx+UFiGMtJxe6zDiCV699HRmMkyO2wA84vdyBYsI6WrEV/SxeF35Q+/1TEnX THpkQdqQYJwDnHtXJSQwVlBfJjhZanP2Lpsz4= MIME-Version: 1.0 Received: by 10.229.106.34 with SMTP id v34mr3627328qco.111.1301674406901; Fri, 01 Apr 2011 09:13:26 -0700 (PDT) Sender: pluknet@gmail.com Received: by 10.229.67.68 with HTTP; Fri, 1 Apr 2011 09:13:26 -0700 (PDT) In-Reply-To: <3AB0D20A-D81D-49EC-BA77-83EACC308796@bsdimp.com> References: <20110331210349.GA4112@freebsd.org> <3AB0D20A-D81D-49EC-BA77-83EACC308796@bsdimp.com> Date: Fri, 1 Apr 2011 20:13:26 +0400 X-Google-Sender-Auth: -jEue5LAPjdNpZe12e5p9CWgz2k Message-ID: From: Sergey Kandaurov To: Warner Losh Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Alexander Best , FreeBSD Current , freebsd-hackers@freebsd.org Subject: Re: issue with devstat_buildmatch(3) and certain strings X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2011 16:13:28 -0000 On 1 April 2011 18:50, Warner Losh wrote: > On Apr 1, 2011, at 5:40 AM, Sergey Kandaurov wrote: >> >> =A0=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (++tempstr >=3D &tstr[= 5]) >> >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0^^^^ >> BTW, >> this game with pointers might prevent devstat(3) from work on big-endian= . > > I'm very curious about your reasoning here. > Warner I meant the above comparison of pointers might not work (I'm not sure, as I have no big-endian to test). Look: # iostat -t da,scsi,pass tempstr=3D0x7fffffffcfa0, &tstr[5]=3D0x7fffffffcfc8 tempstr=3D0x7fffffffcfa8, &tstr[5]=3D0x7fffffffcfc8 tempstr=3D0x7fffffffcfb0, &tstr[5]=3D0x7fffffffcfc8 D'oh.. endianness doesn't matter with arrays *blush (Unless that's some system with decreasing memory addressing. Ok, nevermind.) --=20 wbr, pluknet