From owner-freebsd-fs@FreeBSD.ORG Tue Jul 10 18:43:11 2007 Return-Path: X-Original-To: freebsd-fs@freebsd.org Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4511F16A469 for ; Tue, 10 Jul 2007 18:43:11 +0000 (UTC) (envelope-from jaharkes@cs.cmu.edu) Received: from delft.aura.cs.cmu.edu (DELFT.AURA.CS.CMU.EDU [128.2.206.88]) by mx1.freebsd.org (Postfix) with ESMTP id 2361313C44C for ; Tue, 10 Jul 2007 18:43:11 +0000 (UTC) (envelope-from jaharkes@cs.cmu.edu) Received: from jaharkes by delft.aura.cs.cmu.edu with local (Exim 4.67) (envelope-from ) id 1I8K2D-0007MA-Ke; Tue, 10 Jul 2007 14:02:01 -0400 From: Jan Harkes To: freebsd-fs@freebsd.org Date: Tue, 10 Jul 2007 14:02:00 -0400 Message-Id: <11840905213288-git-send-email-jaharkes@cs.cmu.edu> X-Mailer: git-send-email 1.5.2.1 In-Reply-To: <2c84c1de0707060800t21f3f993mfb53f7975a881ed4@mail.gmail.com> References: <2c84c1de0707060800t21f3f993mfb53f7975a881ed4@mail.gmail.com> Cc: Jan Harkes Subject: [PATCH Coda 4/5] Avoid a panic in insmntque when we pass a NULL mount X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2007 18:43:11 -0000 This reenables some previously disabled code which according to the comment caused a problem during shutdown. But even that is still better than triggering a kernel panic whenever venus is started. --- coda_vfsops.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/coda_vfsops.c b/coda_vfsops.c index 68fdafe..07d0ad1 100644 --- a/coda_vfsops.c +++ b/coda_vfsops.c @@ -183,13 +183,7 @@ coda_mount(struct mount *vfsp, struct thread *td) rootvp = CTOV(cp); rootvp->v_vflag |= VV_ROOT; -/* cp = make_coda_node(&ctlfid, vfsp, VCHR); - The above code seems to cause a loop in the cnode links. - I don't totally understand when it happens, it is caught - when closing down the system. - */ - cp = make_coda_node(&ctlfid, 0, VCHR); - + cp = make_coda_node(&ctlfid, vfsp, VCHR); coda_ctlvp = CTOV(cp); /* Add vfs and rootvp to chain of vfs hanging off mntinfo */ -- 1.5.2.1