From owner-cvs-src@FreeBSD.ORG Wed Feb 28 10:14:02 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D47E316A412; Wed, 28 Feb 2007 10:14:02 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 955B513C494; Wed, 28 Feb 2007 10:14:02 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id l1SAC049090192; Wed, 28 Feb 2007 03:12:00 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 28 Feb 2007 03:12:05 -0700 (MST) Message-Id: <20070228.031205.-1303465006.imp@bsdimp.com> To: doconnor@gsoft.com.au From: "M. Warner Losh" In-Reply-To: <200702281302.18223.doconnor@gsoft.com.au> References: <200702272233.l1RMXocb004983@repoman.freebsd.org> <200702281302.18223.doconnor@gsoft.com.au> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Wed, 28 Feb 2007 03:12:01 -0700 (MST) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/usb umass.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2007 10:14:03 -0000 In message: <200702281302.18223.doconnor@gsoft.com.au> "Daniel O'Connor" writes: : On Wednesday 28 February 2007 09:03, Warner Losh wrote: : > Create a new quirk READ_CAPACITY_OFFBY1 and add a quirk for the : > SanDISK ImageMate that I have that suffers from this problem (the : > SDDR-31). It intercepts the READ_CAPACITY response and adjusts it : > from number of sectors to max sector for devices with this quirk. : > : > Reading the Linux source suggests that there are a host of : > other devices with this issue, including iPods and some popular : > cameras. I've not added quirks for them, since I don't have the : > devices in front of me to test. : : Couldn't you automatically test for this? ie try and read the last sector. : : Obviously if there is a real error in the last sector you'd get a bogus result : but I don't think that is likely to be very common :) To amplify my last answer: No. I couldn't automatically test for this. Others can submit patches if they want it. Warner