From owner-freebsd-current@FreeBSD.ORG Wed Feb 23 22:28:33 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 503DE106566B for ; Wed, 23 Feb 2011 22:28:33 +0000 (UTC) (envelope-from olivier@gid0.org) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 232AB8FC19 for ; Wed, 23 Feb 2011 22:28:33 +0000 (UTC) Received: by iyj12 with SMTP id 12so3289604iyj.13 for ; Wed, 23 Feb 2011 14:28:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.231.171.197 with SMTP id i5mr114558ibz.54.1298500112548; Wed, 23 Feb 2011 14:28:32 -0800 (PST) Received: by 10.231.149.79 with HTTP; Wed, 23 Feb 2011 14:28:32 -0800 (PST) In-Reply-To: References: <20101213214556.GC2038@garage.freebsd.pl> <8662upxg76.fsf@gmail.com> <86lj1s3pv0.fsf@gmail.com> Date: Wed, 23 Feb 2011 23:28:32 +0100 Message-ID: From: Olivier Smedts To: Jason Garrett Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current Subject: Re: Next ZFSv28 patchset ready for testing. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Feb 2011 22:28:33 -0000 2011/2/23 Jason Garrett : > On Mon, Feb 7, 2011 at 08:01, Anonymous wrote: > >> Anonymous writes: >> >> > Pawel Jakub Dawidek writes: >> > >> >> The new patchset is ready for testing: >> >> >> >> =A0 =A0 =A0http://people.freebsd.org/~pjd/patches/zfs_20101212.patch.= bz2 >> >> >> > >> > `-e' option in zdb(8) now looks under /dev/dsk by default >> > >> > =A0 $ zdb -ec blah >> > >> > =A0 Configuration for import: >> > =A0 =A0 =A0 =A0 =A0 vdev_children: 1 >> > =A0 =A0 =A0 =A0 =A0 version: 6 >> > =A0 =A0 =A0 =A0 =A0 vdev_tree: >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 children[0]: >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 phys_path: '/dev/gptid/A-B-C-D-E' >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 path: '/dev/dsk/gptid/A-B-C-D-E' >> > =A0 zdb: can't open 'blah': No such file or directory >> > =A0 Exit 1 >> >> How about below diff then? >> >> %% >> --- cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c~ >> +++ cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c >> @@ -1129,7 +1129,11 @@ zpool_find_import_impl(libzfs_handle_t * >> =A0 =A0 =A0 =A0char *end, **dir =3D iarg->path; >> =A0 =A0 =A0 =A0size_t pathleft; >> =A0 =A0 =A0 =A0nvlist_t *ret =3D NULL; >> +#ifdef sun >> =A0 =A0 =A0 =A0static char *default_dir =3D "/dev/dsk"; >> +#else >> + =A0 =A0 =A0 static char *default_dir =3D "/dev"; >> +#endif >> =A0 =A0 =A0 =A0pool_list_t pools =3D { 0 }; >> =A0 =A0 =A0 =A0pool_entry_t *pe, *penext; >> =A0 =A0 =A0 =A0vdev_entry_t *ve, *venext; >> %% >> >> > >> > =A0 $ zdb -p /dev -ec blah >> > >> > =A0 Traversing all blocks to verify metadata checksums and verify noth= ing >> leaked ... >> > =A0 Assertion failed: (mp->initialized =3D=3D B_TRUE), file >> /usr/src/cddl/lib/libzpool/../../../cddl/contrib/opensolaris/lib/libzpoo= l/common/kernel.c, >> line 130. >> > =A0 Exit 134 >> >> I can't reproduce anymore, at least as of ch188544. >> > > Has there been any recent developments with these patches (eg. Will they > apply and build on latest checkouts?) ? I'm successfuly using the following on latest 9-CURRENT : http://people.freebsd.org/~mm/patches/zfs/v28/head-zfsv28-20110219-nopython= .patch.xz If you want patches for 8-STABLE, look at the directory contents. Cheers --=20 Olivier Smedts=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=A0 _ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 ASCII ribbon campaign ( ) e-mail: olivier@gid0.org=A0 =A0 =A0 =A0 - against HTML email & vCards=A0 X www: http://www.gid0.org=A0 =A0 - against proprietary attachments / \ =A0 "Il y a seulement 10 sortes de gens dans le monde : =A0 ceux qui comprennent le binaire, =A0 et ceux qui ne le comprennent pas."