Date: Sat, 07 Jan 2023 00:32:06 +0000 From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-feedback requested: [Bug 268795] x11/mate-panel: fix build with clang 15 Message-ID: <bug-268795-6497-6hj5Fmfr4C@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-268795-6497@https.bugs.freebsd.org/bugzilla/> References: <bug-268795-6497@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-gnome (Nobody) <gnome@FreeBSD.org> for maintainer-feedback: Bug 268795: x11/mate-panel: fix build with clang 15 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268795 --- Description --- During an exp-run for llvm 15 (see bug 265425), it turned out that x11/mate-panel failed to build with clang 15: clock-location.c:454:22: error: incompatible pointer to integer conversion assigning to 'glong' (aka 'long') from 'char *(int, int)' [-Wint-conversion] sys_timezone =3D timezone; ^ ~~~~~~~~ clock-location.c:462:24: error: incompatible pointer to integer conversion assigning to 'glong' (aka 'long') from 'char *(int, int)' [-Wint-conversion] local_timezone =3D timezone; ^ ~~~~~~~~ This is because 'timezone' as a global external variable does not exist on FreeBSD: it is a glibc-ism. Use struct tm's tm_gmtoff field instead, which = has its sign reversed from the glibc global. There is also no need to manually account for DST, as tm_gmtoff includes that.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-268795-6497-6hj5Fmfr4C>