From owner-freebsd-security@FreeBSD.ORG  Tue Oct  2 21:56:43 2012
Return-Path: <owner-freebsd-security@FreeBSD.ORG>
Delivered-To: freebsd-security@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C18B2106566B
	for <freebsd-security@freebsd.org>;
	Tue,  2 Oct 2012 21:56:43 +0000 (UTC)
	(envelope-from erik@cederstrand.dk)
Received: from csmtp2.one.com (csmtp2.one.com [91.198.169.22])
	by mx1.freebsd.org (Postfix) with ESMTP id 79EFC8FC16
	for <freebsd-security@freebsd.org>;
	Tue,  2 Oct 2012 21:56:43 +0000 (UTC)
Received: from [192.168.1.47] (unknown [176.222.238.90])
	by csmtp2.one.com (Postfix) with ESMTPA id 8884A307C016;
	Tue,  2 Oct 2012 21:56:42 +0000 (UTC)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.0 \(1486\))
From: Erik Cederstrand <erik@cederstrand.dk>
In-Reply-To: <506B6024.8050908@delphij.net>
Date: Tue, 2 Oct 2012 23:56:46 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <87FA4CBA-001F-4C92-8B92-D650A9678864@cederstrand.dk>
References: <9DD86238-51C8-4F38-B7EB-BD773039888B@cederstrand.dk>
	<20121001104901.GJ35915@deviant.kiev.zoral.com.ua>
	<F81C009D-F993-4398-B377-D0B4A0ABA7E3@cederstrand.dk>
	<20121001110805.GL35915@deviant.kiev.zoral.com.ua>
	<CAF6rxgmKWfefr5tvM3-0PQM3EKWockkb8A4sCiyYekxs5b4fGA@mail.gmail.com>
	<ECC8690A-9B5D-41FB-BF1D-CC170147BEEC@cederstrand.dk>
	<CAF6rxgnkLcoL4eAbKxC=-OY=G9O--TLYT8C2xEtu1u7yrNUD5A@mail.gmail.com>
	<506B6024.8050908@delphij.net>
To: d@delphij.net
X-Mailer: Apple Mail (2.1486)
Cc: Konstantin Belousov <kostikbel@gmail.com>,
	Eitan Adler <lists@eitanadler.com>,
	"freebsd-security@freebsd.org" <freebsd-security@freebsd.org>
Subject: Re: Opinion on checking return value of setuid(getuid())?
X-BeenThere: freebsd-security@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Security issues \[members-only posting\]"
	<freebsd-security.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-security>, 
	<mailto:freebsd-security-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-security>
List-Post: <mailto:freebsd-security@freebsd.org>
List-Help: <mailto:freebsd-security-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-security>, 
	<mailto:freebsd-security-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Oct 2012 21:56:43 -0000

Den 02/10/2012 kl. 23.44 skrev Xin Li <delphij@delphij.net>:
> On 10/02/12 07:45, Eitan Adler wrote:
>> On 2 October 2012 08:38, Erik Cederstrand <erik@cederstrand.dk>
>> wrote:
>>> Den 01/10/2012 kl. 13.55 skrev Eitan Adler
>>> <lists@eitanadler.com>:
>>>=20
>>>> On 1 October 2012 07:08, Konstantin Belousov
>>>> <kostikbel@gmail.com> wrote:
>>>>> I do not believe in the dreadful 'flood ping' security
>>>>> breach. Is a local escalation possible with non-dropped root
>>>>> ?
>>>>=20
>>>> It is clearly a local escalation: a non-root user can do
>>>> something which was intended only for root. It is a different
>>>> question how serious the breach is.
>>>=20
>>> Are there any objections to the path I attached in my first post?
>>> To the approach in general? If not, I'll send a PR so it doesn't
>>> get lost.
>> Not by me. Please cc me on the PR as I'll commit if no one else
>> objects.
>=20
> It doesn't seem hurt in general but if you are going to commit it
> please also change the other instances in the base system.

I'll do my best. There are around 200 of these in base, but some are the =
result of macro expansion so it may not be too bad.

Erik=