From owner-freebsd-net@freebsd.org Mon Nov 9 19:48:28 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 25FAC46BECB for ; Mon, 9 Nov 2020 19:48:28 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CVM4C02KWz3nx3 for ; Mon, 9 Nov 2020 19:48:26 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-qv1-f41.google.com with SMTP id ec16so4686113qvb.0 for ; Mon, 09 Nov 2020 11:48:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bf7/HzsAqjXbUVr8oJjYWGj+NaLxqBmeN8sh61zzFzs=; b=jzqZQ2wGnqRVX8+kvIhJSs+33uXrA3NRyYTXNGj+QF71jNqmcawSLxKywaC/IP/TNU W9Yy2nAlziEMyQC4CoSZ1K4ixpKU6XMjaQyR5+/+AwTXwLsKXLAbW9HP0mrNqjEhDfdb d79ooPMYstYDhGxhQwBtB6pMxJEHxu3Wp4sAYwrWxXxh2xF1AqkoETDeyJzt9EeMiZdI nsJkkb6gY3+B1BntyM2cQuyC0C8IGq+UMnyVvTLsHXLLPb4x498zVfr04l0/SyVR4cZl vP+Y0bBlIxiKo8hV9Qf6Cl6lbMZSk1IiFR3EeXZkmi7TDgRhM/ziWcJ663Map82bb00B f7eQ== X-Gm-Message-State: AOAM533y4DlOcSGGkB1shAWDVwskDOA+OdUwtnE/TmNZqpOCrE+iPXAg ayuhs7sp5KdjOM6MZdslPeZLCljkF6I= X-Google-Smtp-Source: ABdhPJycSpqT9mxIpDopVOUkUFlrITSsVq/FZnvnvlproHngOQC8y5RVwvx0oT1GOt25zOzC8rEO1g== X-Received: by 2002:a05:6214:10c4:: with SMTP id r4mr15684338qvs.62.1604951305819; Mon, 09 Nov 2020 11:48:25 -0800 (PST) Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com. [209.85.219.170]) by smtp.gmail.com with ESMTPSA id a1sm756730qtw.11.2020.11.09.11.48.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Nov 2020 11:48:25 -0800 (PST) Received: by mail-yb1-f170.google.com with SMTP id i193so9332717yba.1 for ; Mon, 09 Nov 2020 11:48:25 -0800 (PST) X-Received: by 2002:a25:bbd2:: with SMTP id c18mr22134402ybk.442.1604951305283; Mon, 09 Nov 2020 11:48:25 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Eric Joyner Date: Mon, 9 Nov 2020 11:47:49 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: iflib tx watchdog doesn't appear that it can work anymore To: Ryan Stone Cc: freebsd-net , Piotr.Pietruszewski@intel.com X-Rspamd-Queue-Id: 4CVM4C02KWz3nx3 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ricera10@gmail.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=ricera10@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RCVD_COUNT_THREE(0.00)[4]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_SENDER(0.30)[erj@freebsd.org,ricera10@gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.219.41:from]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[erj@freebsd.org,ricera10@gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[209.85.219.41:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.219.41:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.219.41:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-net] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2020 19:48:28 -0000 I'll add Piotr, the author of your linked patch, to this thread. Are you seeing a problem connected to the watchdog? Piotr tells me that IFLIB_QUEUE_WORKING isn't used now, but it wasn't even used before his patch. - Eric On Wed, Nov 4, 2020 at 8:47 AM Ryan Stone wrote: > https://svnweb.freebsd.org/base?view=revision&revision=356310 > > As of r356310, there does not appear to be a way that ift_qstatus can > be set to anything but IFLIB_QUEUE_IDLE. As a result, I don't see > that there is any way for the watchdog to ever fire. > > I think that iflib has missed setting ift_qstatus to > IFLIB_QUEUE_WORKING when packets are enqueued on the rx ring. > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >