From owner-freebsd-hackers Thu Feb 12 03:05:20 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id DAA12336 for hackers-outgoing; Thu, 12 Feb 1998 03:05:20 -0800 (PST) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from fly.HiWAAY.net (root@fly.HiWAAY.net [208.147.154.56]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id DAA12327 for ; Thu, 12 Feb 1998 03:05:16 -0800 (PST) (envelope-from sprice@hiwaay.net) Received: from bonsai.hiwaay.net (tnt1-231.HiWAAY.net [208.147.147.231]) by fly.HiWAAY.net (8.8.8/8.8.6) with SMTP id FAA00069; Thu, 12 Feb 1998 05:05:09 -0600 (CST) Message-ID: <34E2D7C6.59E2B600@hiwaay.net> Date: Thu, 12 Feb 1998 05:06:46 -0600 From: Steve Price X-Mailer: Mozilla 3.04Gold (X11; I; FreeBSD 3.0-CURRENT i386) MIME-Version: 1.0 To: ac199@hwcn.org CC: jkh@time.cdrom.com, hackers@FreeBSD.ORG Subject: Re: ftp://freebsd.org - RIP References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Tim Vanderhoek wrote: > > They should put them in the pr so that 1) there is a permanent > record, 2) incoming doesn't get over-cluttered, 3) they're easy > to access and the committer doesn't have to worry about making > sure some silly 2k file in incoming/ is removed. Yes, putting them in a PR is TRT, but they should be uuencoded tarballs. All to many times I have had to spend extra time sorting out snarf-and-barf errors. I would go so far as to say all but the most trivial of patches should be done this way. This brings up another point, whether diffs should be context or unified. I personally prefer unified diffs but don't want to start any flame wars. The place that documents how to store the diffs/ portballs in a PR should also specify (with zero exceptions) diffs in one format or the other. IMHO, of course. Steve > Most ports are pretty small. > > -- > tIM...HOEk > OPTIMIZATION: the process of using many one-letter variables names > hoping that the resultant code will run faster. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe hackers" in the body of the message