From owner-freebsd-fs@FreeBSD.ORG Wed Sep 28 08:50:55 2005 Return-Path: X-Original-To: fs@freebsd.org Delivered-To: freebsd-fs@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B604716A425 for ; Wed, 28 Sep 2005 08:50:55 +0000 (GMT) (envelope-from peadar.edwards@gmail.com) Received: from zproxy.gmail.com (zproxy.gmail.com [64.233.162.206]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9115743D49 for ; Wed, 28 Sep 2005 08:50:54 +0000 (GMT) (envelope-from peadar.edwards@gmail.com) Received: by zproxy.gmail.com with SMTP id z31so11480nzd for ; Wed, 28 Sep 2005 01:50:54 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=MNlY/MpYPLJbfeda06j4OJ/7A5viC/CYrw4Fv66MWHlIKGqsfahZZ+jxiGgZFz3jnC+tPaah+ul/gWTeYRwazdITAMet/JOxp2EsbNbVJ1ZTE/fTugh0gSKPokcejGS1tyw/uBSzVLUo+Nj4d1cA2ltnNNMzCHy/zwGU+G0K0Cw= Received: by 10.36.12.9 with SMTP id 9mr3358655nzl; Wed, 28 Sep 2005 01:50:54 -0700 (PDT) Received: by 10.36.68.16 with HTTP; Wed, 28 Sep 2005 01:50:53 -0700 (PDT) Message-ID: <34cb7c840509280150212d2bba@mail.gmail.com> Date: Wed, 28 Sep 2005 09:50:53 +0100 From: Peter Edwards To: Scott Long In-Reply-To: <433A32AE.1030802@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <200509280537.j8S5b1rN050598@corbulon.video-collage.com> <433A32AE.1030802@samsco.org> Cc: gayn.winters@bristolsystems.com, re@freebsd.org, fs@freebsd.org, Mikhail Teterin Subject: Re: can not mount a large FAT32 filesystem X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Peter Edwards List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2005 08:50:55 -0000 On 9/28/05, Scott Long wrote: > Mikhail Teterin wrote: > > Thank you very much, Peter! > > > > Your patch below makes the card "mountable" and usable. I'm copying > > my photos right now. > > > > I think, this should be merged into 6.0 -- these cards are a popular > > item... Thanks, again! > > > > -mi > > > > Index: msdosfs_vfsops.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > RCS file: /nfs/dyson/export/home/petere/freebsd-cvs/cvs/FreeBSD/src/sys= /fs/msdosfs/msdosfs_vfsops.c,v > > retrieving revision 1.144 > > diff -u -r1.144 msdosfs_vfsops.c > > --- msdosfs_vfsops.c 24 Mar 2005 07:36:13 -0000 1.144 > > +++ msdosfs_vfsops.c 27 Sep 2005 09:40:19 -0000 > > @@ -512,9 +512,7 @@ > > #endif /* !MSDOSFS_LARGE */ > > > > if (pmp->pm_RootDirEnts =3D=3D 0) { > > - if (bsp->bs710.bsBootSectSig2 !=3D BOOTSIG2 > > - || bsp->bs710.bsBootSectSig3 !=3D BOOTSIG3 > > - || pmp->pm_Sectors > > + if (pmp->pm_Sectors > > || pmp->pm_FATsecs > > || getushort(b710->bpbFSVers)) { > > error =3D EINVAL; > > Might this be an attempt by the manufacturer to avoid the potential > patent litigation from using msdosfs? I.e. create a slightly > non-conformant filesystem so that it can't claim to explicitely be > msdosfs/vfat/fat32/whatever, thereby avoiding the patents on those > technologies? > > Since these checks are done after other magic number checks, it's likely > safe. I'm fine with it going into RELENG_6 once it hass been committed > to HEAD. > > Scott As I said, I can't see any reference to this signature in the "official" specification for the FAT boot-sector anyway, so I doubt you could claim it wasn't a FAT boot-sector based on that change anyway. I imagine the've just relaxed the spec, and new implementations don't have the baggage of 20 years of evolving operating systems and disk technology lying about :-) I'll commit it this evening.