Date: Tue, 5 Dec 2017 07:46:43 -0800 From: Devin Teske <devin@shxd.cx> To: cem@freebsd.org Cc: Eitan Adler <eadler@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge usr.bin/sponge/tests usr.bin/tee Message-ID: <8090FD05-E35B-4BC2-A89C-281EE8EBAA0B@shxd.cx> In-Reply-To: <CAG6CVpW2N16jKMNnU22NDKH8A2oOzu0BcCLvsqrUrXXUxmuQvw@mail.gmail.com> References: <201712050355.vB53tApl074041@repo.freebsd.org> <CAG6CVpXGATey4VC6u0seN=3Sb%2BzvYTve9bJ9WY%2BpUDtPJjHHkw@mail.gmail.com> <CAG6CVpW2N16jKMNnU22NDKH8A2oOzu0BcCLvsqrUrXXUxmuQvw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Dec 4, 2017, at 8:40 PM, Conrad Meyer <cem@freebsd.org> wrote: >=20 >> On Mon, Dec 4, 2017 at 8:30 PM, Conrad Meyer <cem@freebsd.org> wrote: >>> On Mon, Dec 4, 2017 at 7:55 PM, Eitan Adler <eadler@freebsd.org> wrote: >>> Author: eadler >>> Date: Tue Dec 5 03:55:10 2017 >>> New Revision: 326554 >>> URL: https://svnweb.freebsd.org/changeset/base/326554 >>>=20 >>> Log: >>> sponge(1): initial commit >>>=20 >>> sponge(1) is a utility that reads input until >>> complete, then opens the output file, then >>> writes to it. This makes it useful in pipelines >>> that read and write to the same file. >>>=20 >>> Reviewed by: wblock, jilles, imp, cem, danfe (all: various iterations)= >>=20 >> I don't recall reviewing this in any iteration, but I could be mistaken. >>=20 >> Best, >> Conrad >=20 > In fact I don't think any of the listed reviewers approved the change, > at least in phabricator. The "Reviewed by" line signifies not just > giving feedback, but approval of the final (or near-final) change. >=20 > Best, > Conrad >=20 If true, upsetting. You have people like myself that are ultra patient and w= ait for the approvals. For example, https://reviews.freebsd.org/D10006 which= has been in review for 8 months now and I have been working on it for a tot= al of 5 years now. It is more than a little hurtful to put in such effort and then see someone e= lse run roughshod past the group. --=20 Devin=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8090FD05-E35B-4BC2-A89C-281EE8EBAA0B>