From owner-freebsd-mips@FreeBSD.ORG Wed May 26 05:30:54 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 72BB9106567C for ; Wed, 26 May 2010 05:30:54 +0000 (UTC) (envelope-from neelnatu@gmail.com) Received: from mail-pz0-f183.google.com (mail-pz0-f183.google.com [209.85.222.183]) by mx1.freebsd.org (Postfix) with ESMTP id 4823F8FC30 for ; Wed, 26 May 2010 05:30:53 +0000 (UTC) Received: by pzk13 with SMTP id 13so4678687pzk.13 for ; Tue, 25 May 2010 22:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=pj2SCSl2MHNeWU/AkTQ7N7ZAQ0HZ8dDXz12zJXRdQrY=; b=Q7+6PNgC1ny3E0oRZWQps2HDpSM+IHuILiSkXXfVcq6hT1h689106Zx5jDF6ksUBGV ljrmUPe5UDZLrlRJp5tVqN2Ftnxij9e7caNq48Nmwbic7kbuW400xiaRobK4IJkaS+iA XBRZfl2HaG1AO9M7Im8Cx99ZM9z5J6Zdc4wdM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=anqJTeRa4gTWDGL2qkSb/LkF7BY/5YwiDc48SnReEQB+7lQX+slXcC9HsFdqlUw/iW O+3MhNHVGc6SkllDITbJf34AlwK8owtZu5id/VXW+zU2FPjXmb9fSa/1MNFQcYdJPH3a ngubBT3EjPcZ55QkKHvv1TWi0RODH/SycjH40= MIME-Version: 1.0 Received: by 10.142.209.4 with SMTP id h4mr5425050wfg.245.1274851851189; Tue, 25 May 2010 22:30:51 -0700 (PDT) Received: by 10.142.172.9 with HTTP; Tue, 25 May 2010 22:30:51 -0700 (PDT) In-Reply-To: References: Date: Tue, 25 May 2010 22:30:51 -0700 Message-ID: From: Neel Natu To: "C. Jayachandran" Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-mips@freebsd.org Subject: Re: Fixes to the new pagetable page allocation code. X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 May 2010 05:30:54 -0000 Hi JC, On Tue, May 25, 2010 at 10:03 PM, C. Jayachandran wrote: > The attached patch (also at > http://people.freebsd.org/~jchandra/for-review/pmap-alloc-page-fix.diff) > has two fixes for the new pagetable page allocation code, one to > handle NULL return from the allocating function, and another to call > VM_WAIT in cases we can wait. It also removes the variable 'req' left > over from an earlier change. > > Please let me know if you have any comments... > Your patch looks fine. Checking the value of 'ptdpg' is redundant given that you are passing in M_WAITOK. I don't think we expect the allocation to fail now that you have added the check for M_WAITOK in zone allocator function. best Neel > JC. >