From owner-freebsd-toolchain@FreeBSD.ORG  Sun Nov  6 20:38:38 2011
Return-Path: <owner-freebsd-toolchain@FreeBSD.ORG>
Delivered-To: freebsd-toolchain@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1233)
	id DD53D1065678; Sun,  6 Nov 2011 20:38:38 +0000 (UTC)
Date: Sun, 6 Nov 2011 20:38:38 +0000
From: Alexander Best <arundel@freebsd.org>
To: Ed Schouten <ed@80386.nl>
Message-ID: <20111106203838.GA74911@freebsd.org>
References: <20111105102102.GA54596@freebsd.org>
	<20111106172835.GO2258@hoeg.nl>
	<20111106203316.GA73216@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20111106203316.GA73216@freebsd.org>
Cc: freebsd-toolchain@freebsd.org
Subject: Re: [poc] buildkernel + clang + -Werror
X-BeenThere: freebsd-toolchain@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Maintenance of FreeBSD's integrated toolchain
	<freebsd-toolchain.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
	<mailto:freebsd-toolchain-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-toolchain>
List-Post: <mailto:freebsd-toolchain@freebsd.org>
List-Help: <mailto:freebsd-toolchain-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
	<mailto:freebsd-toolchain-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Nov 2011 20:38:38 -0000

On Sun Nov  6 11, Alexander Best wrote:
> On Sun Nov  6 11, Ed Schouten wrote:
> > Hello Alexander!
> > 
> > Even though that I agree that Clang is sometimes a bit picky, we'd
> > better spend the time fixing the actual bugs in the code. I am more than
> > willing to commit patches that fix actual warnings/errors in code.

however it would be nice, if you could take a look at PR 162321.

cheers.
alex

> 
> the problem is, something like
> 
> uint x;
> 
> if (x < 0) ...
> 
> clang will warn about this, yet it is 100% valid code so my vote would be to
> make such an error into a warning.
> 
> the same with 
> 
> int x;
> 
> x = x;
> 
> i believe in both cases clang is too picky.
> 
> cheers.
> alex
> 
> > 
> > -- 
> >  Ed Schouten <ed@80386.nl>
> >  WWW: http://80386.nl/
> 
>