From owner-svn-src-all@FreeBSD.ORG Fri Jul 11 17:54:52 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7FCF8E6A; Fri, 11 Jul 2014 17:54:52 +0000 (UTC) Received: from mail-wi0-x234.google.com (mail-wi0-x234.google.com [IPv6:2a00:1450:400c:c05::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9AD1424BB; Fri, 11 Jul 2014 17:54:51 +0000 (UTC) Received: by mail-wi0-f180.google.com with SMTP id n3so89513wiv.1 for ; Fri, 11 Jul 2014 10:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=BpPjzIRysf2LR3LP8mcdjuqiNT+DT/a2VUvW5ib5e2E=; b=ttWT0UXzBFRTGfaSZiUyUTFbu7WexLIoWd+KuFOkS7Ae+nOc1GosB0XM1ztciaY5Yv N8SSOzYQwmjtOnny2zozudggUt2wf3kjsTr6SXE2wDxgtSZH8q9aOCdyHW7u8PUXjcDW 5//Os7oBXtlAnUph/WiyS3O3eVR9MWJDCeUHebdvv5TWpXcRrZSaE+kTpqYckQ2zVpmm 3j9eo9GtbLWKIOD9hce8S2WzwqwrS1l0qJ6G4pkOvC/vnbPJUxdI+r0azwJRkKTQvL9N TaZlXgPBD+2yqXx9grBhHyTEGILTb7jC1hWfz/6RMBYG92n69/ZacApVf+k1omCspdTb YKJw== X-Received: by 10.194.92.115 with SMTP id cl19mr428034wjb.29.1405101285742; Fri, 11 Jul 2014 10:54:45 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id fg1sm9805281wic.17.2014.07.11.10.54.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Jul 2014 10:54:44 -0700 (PDT) Sender: Baptiste Daroussin Date: Fri, 11 Jul 2014 19:54:42 +0200 From: Baptiste Daroussin To: John Baldwin Subject: Re: Phabric IDs / URLs in commits Message-ID: <20140711175442.GJ93051@ivaldir.etoilebsd.net> References: <201407111616.s6BGGQFW060195@svn.freebsd.org> <201407111238.23391.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ELVYuRnMxQ5nnKRy" Content-Disposition: inline In-Reply-To: <201407111238.23391.jhb@freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jul 2014 17:54:52 -0000 --ELVYuRnMxQ5nnKRy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 11, 2014 at 12:38:23PM -0400, John Baldwin wrote: > On Friday, July 11, 2014 12:16:26 pm John Baldwin wrote: > > Author: jhb > > Date: Fri Jul 11 16:16:26 2014 > > New Revision: 268531 > > URL: http://svnweb.freebsd.org/changeset/base/268531 > >=20 > > Log: > > Fix some edge cases with rewinddir(): > > - In the unionfs case, opendir() and fdopendir() read the directory's= full > > contents and cache it. This cache is not refreshed when rewinddir(= ) is > > called, so rewinddir() will not notice updates to a directory. Fix= this > > by splitting the code to fetch a directory's contents out of > > __opendir_common() into a new _filldir() function and call this from > > rewinddir() when operating on a unionfs directory. > > - If rewinddir() is called on a directory opened with fdopendir() bef= ore > > any directory entries are fetched, rewinddir() will not adjust the = seek > > location of the backing file descriptor. If the file descriptor pa= ssed > > to fdopendir() had a non-zero offset, the rewinddir() will not rewi= nd to > > the beginning. Fix this by always seeking back to 0 in rewinddir(). > > This means the dd_rewind hack can also be removed. > > =20 > > While here, add missing locking to rewinddir(). > > =20 > > CR: https://phabric.freebsd.org/D312 > > Reviewed by: jilles > > MFC after: 1 week >=20 > Just picking my own commit here as a sample case. >=20 > I think we should be annotating commits with phabricator code reviews in = some=20 > way when a change has gone through that review. It is very useful to get= back > to the review details from the commit log message in svnweb, etc. >=20 > I can see a number of different ways to do this, but I do think it would = be > nice to pick a consistent way to do it. >=20 > Things to consider: >=20 > 1) The tag ("CR:" is what I used above). I don't care, just pick one. I > chose CR since Warner used it previously. Whatever we decide, we shou= ld > add it to the template. >=20 > 2) ID vs full URL. For PRs we just list the bug ID and not the full URL > (same for Coverity). I would be fine with that so long as someone hac= ks > up svnweb to convert the IDs into links (the way it handles PR bug > numbers). OTOH, if you use the full URL you get that for free in svnw= eb, > and you also get it in mail clients, etc. It helps that the URL isn't= but > so long. for bugs we could use http://bugs.FreeBSD.org/ that also works and = it is short :) >=20 > This is more of a pie-in-the-sky, but it would be _really_ nice if arcani= st=20 > were hacked up to support our local commit template and would auto popula= te=20 > the 'Reviewed by' and 'CR' (or whatever it ends up being called) fields s= o one=20 > could use 'arc commit'. I'm planning to work on this but I first need to finish tracking 2 bugs it = has with svn. regards, Bapt --ELVYuRnMxQ5nnKRy Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlPAJOIACgkQ8kTtMUmk6EzmRQCfTYu5FgBQq4grYkus3Aq0wxBD v5MAn2GhQC7eOfSzOVhEs16bgK+ryBA9 =GqKd -----END PGP SIGNATURE----- --ELVYuRnMxQ5nnKRy--