From owner-cvs-src@FreeBSD.ORG Thu Apr 26 16:02:50 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4BCA316A400; Thu, 26 Apr 2007 16:02:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 1042E13C48A; Thu, 26 Apr 2007 16:02:48 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l3QG2al3076186; Thu, 26 Apr 2007 12:02:41 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Nate Lawson Date: Thu, 26 Apr 2007 11:49:01 -0400 User-Agent: KMail/1.9.6 References: <20070425162233.8CCFC16A59E@hub.freebsd.org> <462F8672.7040200@root.org> <462FCC83.3080208@root.org> In-Reply-To: <462FCC83.3080208@root.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200704261149.01661.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 26 Apr 2007 12:02:41 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3165/Thu Apr 26 09:03:24 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/acpica acpi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2007 16:02:50 -0000 On Wednesday 25 April 2007 05:47:47 pm Nate Lawson wrote: > Nate Lawson wrote: > > John Baldwin wrote: > >> jhb 2007-04-25 16:22:18 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/dev/acpica acpi.c > >> Log: > >> Use a tighter check to see if a resource allocation request is for a > >> specific request and thus should first try to be allocated from the > >> sys_resource pool. This avoids using the sys_resource pool for wildcard > >> requests that have bounded ranges coming from cbb(4) and Host-PCI pcib(4) > >> drivers. > >> > >> Tested by: Andrea Bittau > >> Sleuthing by: Andrea Bittau as well > >> > >> Revision Changes Path > >> 1.235 +1 -1 src/sys/dev/acpica/acpi.c > > > > I think I'll test this to see if it helps my via 8235 ata survive boot. > > Yay, my laptop now boots with this change. Thanks! > > BTW, I've been thinking about sysres issues in general. One is that > sometimes ACPI tables define regions that are actually split with nexus. > Would it make sense to change rman to have a split model where if a > request can be partially satisfied by this pool and a parent pool, we > can split the request while returning a struct resource *? struct > resource would probably have to be changed to allow a linked list of > internal storage with pointers to parent pools. > > What do you think? Those allocations should fail. You shouldn't have a single resource cross both a fixed-address system-resource and a variable "free" address. -- John Baldwin