From owner-svn-ports-all@freebsd.org Mon Sep 17 12:53:11 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58A42109CDDA; Mon, 17 Sep 2018 12:53:11 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id A3C077B745; Mon, 17 Sep 2018 12:53:10 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id 1t1Qgx6BEp5A11t1SgQfus; Mon, 17 Sep 2018 06:53:02 -0600 X-Authority-Analysis: v=2.3 cv=JLKPTPCb c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=8nJEP1OIZ-IA:10 a=JBFolyDoGHsA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=9p80EfzXezJhSfh2YiIA:9 a=wPNLvfGTeEIA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id A6516EB; Mon, 17 Sep 2018 05:54:12 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w8HCqxLA071800; Mon, 17 Sep 2018 05:52:59 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w8HCqx3V071797; Mon, 17 Sep 2018 05:52:59 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201809171252.w8HCqx3V071797@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Craig Leres cc: =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r479877 - in head: lang/rust lang/rust/files mail/thunderbird/files www/firefox-esr/files www/firefox/files In-Reply-To: Message from Craig Leres of "Sun, 16 Sep 2018 11:34:48 -0700." <0a896f2c-79d5-3ec9-e00e-6676c557a4e4@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Date: Mon, 17 Sep 2018 05:52:59 -0700 X-CMAE-Envelope: MS4wfBldooBZjnfb92Dxi+RbpctI1Biibl6hnev2rmP/6pL1kF2CBgX4sJS+9Cytti3OYxXVhu4CM4A93F0CAe4u1AxvBej/jaa2yBn8r+27myGfqRT7xVqn 6sEv8ljvGdwg0glkK5GqiXhWLl338BXhOdYUu/n1ndju/xQKZ1L/xUsCJr2ZOxsjbYymKZn1KkMVdCL5ZbX2DO22SP/Oahpya5+Nj865aCXSnmSIilo9El/n BrCcDA3jtckFA2UEpF6OD5g0C1mYcC9n91Rei41Itwh6qJivjrF8D61tle7dTuqnaE+nN0HeXJFP86CIkH/nhV8YVqzezsSlQEVErahjfeGeKAd54v/QIJfr UykNhIXw X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 12:53:11 -0000 In message <0a896f2c-79d5-3ec9-e00e-6676c557a4e4@freebsd.org>, Craig Leres writ es: > On 9/15/18 10:57 PM, Jean-Sébastien Pédron wrote: > > Author: dumbbell > > Date: Sun Sep 16 07:57:08 2018 > > New Revision: 479877 > > URL:https://svnweb.freebsd.org/changeset/ports/479877 > > > > Log: > > lang/rust: Update to 1.29.0 > > This doesn't build for me under 11.2-RELEASE-p3 (I've attached a > poudriere build log). I see rust has a LIB_DEPENDS for security/libssh2 > (which is 1.8.0). But the new rust appears to have its own local copy of > libssh 1.8.1 which is what's failing to build I assume because it's > picking up the port's libssh2 include files instead of the port local copy. > > I tried removing security/libssh2 from LIB_DEPENDS but that didn't fix > it. I think what will work is to add the local libssh 1.8.1 to the > include path. > > Craig > > /wrkdirs/usr/ports/lang/rust/work/rustc-1.29.0-src/src/vendor/libssh2-sys/lib > ssh2/src/channel.c:2262:44: > error: use of undeclared identifier 'LIBSSH2_ERROR_CHANNEL_WINDOW_FULL' > return _libssh2_error(session, > LIBSSH2_ERROR_CHANNEL_WINDOW_FULL, > ^ > 1 error generated. > > /wrkdirs/usr/ports/lang/rust/work/rustc-1.29.0-src/src/vendor/libssh2-sys/lib > ssh2/src/hostkey.c:526:10: > error: use of undeclared identifier 'LIBSSH2_HOSTKEY_HASH_SHA256' > case LIBSSH2_HOSTKEY_HASH_SHA256: > ^ > 1 error generated. Yes, the issue is this: slippy$ ag LIBSSH2_ERROR_CHANNEL_WINDOW_FULL src/vendor/libssh2-sys/libs sh2/include/libssh2.h 486:#define LIBSSH2_ERROR_CHANNEL_WINDOW_FULL -47 slippy$ ag LIBSSH2_ERROR_CHANNEL_WINDOW_FULL /usr/local/include/libssh/l ibssh.h slippy$ -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.